Эх сурвалжийг харах

S-cfc-163: 实测全绿,后端已于前序 merge 9e1fc2f25 实现 chat.entry.memberGate 契约(AC-1/2/3 条款),无需代码改动

E2E Test Bot 4 өдөр өмнө
parent
commit
0a3e221f8

+ 278 - 0
cfc-backend/src/test/java/com/etotem/cfc/unit/MembershipChatMemberGateContractTest.java

@@ -0,0 +1,278 @@
+package com.etotem.cfc.unit;
+
+import com.etotem.cfc.dto.AiGateResult;
+import com.etotem.cfc.entity.FamilyMembership;
+import com.etotem.cfc.entity.MembershipLevel;
+import com.etotem.cfc.entity.User;
+import com.etotem.cfc.mapper.FamilyMembershipMapper;
+import com.etotem.cfc.mapper.MembershipLevelMapper;
+import com.etotem.cfc.mapper.UserMapper;
+import com.etotem.cfc.service.MembershipService;
+import com.etotem.cfc.service.SysConfigService;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.lang.reflect.Field;
+import java.util.Collections;
+import java.util.Date;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+/**
+ * 契约级单测:{@code chat.entry.memberGate} — 「聊天功能仅会员可见」后端判据(能力键前项)。
+ *
+ * <p><b>溯源</b>:CHAT-2026-11-12-V1 §三 S1-1,需求原话「小程序上,聊天功能只有会员才能看到,非会员入口都不能看」。
+ * 关键变化(§二):此前各页自行判断会员态、口径不一;本变更要求统一用 {@code POST /api/ai/gate}
+ * 返回的 {@code data.isActive} 作为唯一可见性判据——该字段按<b>真实付费记录</b>填充
+ * ({@code users.member_expire_time > now} 或 {@code family_memberships.payment_status='paid'}
+ * 且 {@code end_date > now}),与运营开关 {@code ai.coach.member_gate_enabled}、当日配额、
+ * {@code canUse/status} 全部解耦,fail-closed(无 token/接口异常/字段缺失一律 false)。</p>
+ *
+ * <p><b>被验契约点(AC-1 ~ AC-3,对应三条验收规则)</b>:</p>
+ * <ul>
+ *   <li><b>AC-1 唯一判据</b>:{@link AiGateResult#getIsActive()} 仅依赖实际付费记录计算,不受门控开关影响。</li>
+ *   <li><b>AC-2 fail-closed</b>:userId 为 null、查不到用户、DB 抛异常 → 一律视为未激活({@code isActive=false})。</li>
+ *   <li><b>AC-3 开关解耦</b>:运营开关关闭时 {@code isActive} 仍需按真实付费记录判定,不能退化为 canUse。</li>
+ * </ul>
+ *
+ * <p><b>测试范围</b>:{@link MembershipService#checkAiFeatureGate(Long)}。纯 Mockito + 反射注入,
+ * 不依赖 Spring 上下文、不连 DB、不调 LangGraph。</p>
+ *
+ * <p><b>RED/GREEN 状态说明</b>:本能力在 merge {@code 9e1fc2f25 feat(ai): AI 使用会员门禁后端 T-B0/T-B1/T-B2}
+ * 中已实现({@code AiGateResult.isActive} 在开关分支之前赋值,fail-closed 三路兜底均成立),
+ * 本次合入的 {@code 3d35ab714} 只做前端收敛。故本测试<strong>预期全绿</strong>——属于「契约先行补测」
+ * 后确认后端已满足的情形,测试用于冻结行为不变并作为后续回归锚点。如未来有人意外改动
+ * {@code isActive} 计算路径导致断言失败,即触发 GREEN 修复信号。</p>
+ *
+ * <p><b>权限流</b>:{@code /api/ai/gate} 由 {@code JwtInterceptor} 前置校验 JWT,无 token 时请求不进本端点,
+ * 因此 fail-closed 在「无 token」维度已由拦截器负责;本类以「有 token 但查不到对应用户」和
+ * 「查用户时 DB 异常」两种情形覆盖 fail-closed。</p>
+ */
+class MembershipChatMemberGateContractTest {
+
+    /** S1-1 指定的运���开关配置键 */
+    private static final String GATE_ENABLED_KEY = MembershipService.AI_MEMBER_GATE_CONFIG_KEY;
+
+    private MembershipService service;
+    private UserMapper userMapper;
+    private FamilyMembershipMapper membershipMapper;
+    private MembershipLevelMapper levelMapper;
+    private SysConfigService sysConfigService;
+
+    @BeforeEach
+    void setUp() throws Exception {
+        service = new MembershipService();
+        userMapper = mock(UserMapper.class);
+        membershipMapper = mock(FamilyMembershipMapper.class);
+        levelMapper = mock(MembershipLevelMapper.class);
+        sysConfigService = mock(SysConfigService.class);
+        inject(service, "userMapper", userMapper);
+        inject(service, "membershipMapper", membershipMapper);
+        inject(service, "levelMapper", levelMapper);
+        inject(service, "sysConfigService", sysConfigService);
+    }
+
+    // =====================================================================
+    // AC-1 唯一判据:isActive 仅依赖付费记录
+    // =====================================================================
+
+    /**
+     * AC-1a:有效家庭会员 → isActive=true(支付状态=paid,endDate 在未来)。
+     * 对应需求:「唯一判据 = POST /api/ai/gate 返回 data.isActive === true」中的真值场景。
+     */
+    @Test
+    @DisplayName("AC-1a:有效家庭付费会员 → isActive=true")
+    void ac1_activeFamilyMembership_isActiveTrue() {
+        long userId = 10L;
+        long familyId = 100L;
+        Date farFuture = new Date(System.currentTimeMillis() + 30L * 86_400_000L);
+
+        User user = freshUser(userId, familyId, "FREE", null);
+        FamilyMembership fm = activeMembership(familyId, "FAMILY", "paid", farFuture);
+
+        when(userMapper.selectById(userId)).thenReturn(user);
+        when(membershipMapper.selectOne(any())).thenReturn(fm);
+        when(levelMapper.selectOne(any())).thenReturn(freshLevel("FAMILY", 3));
+
+        AiGateResult result = service.checkAiFeatureGate(userId);
+
+        assertNotNull(result);
+        assertTrue(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] 有效家庭付费会员应使 isActive=true(S1-1:唯一判据取真实付费记录)");
+    }
+
+    /**
+     * AC-1b:过期会员 → isActive=false。即使曾经付费,只要 endDate ≤ now 即视为非活跃,入口隐藏。
+     */
+    @Test
+    @DisplayName("AC-1b:过期家庭会员 → isActive=false(入口必隐藏)")
+    void ac1_expiredFamilyMembership_isActiveFalse() {
+        long userId = 11L;
+        long familyId = 101L;
+        Date past = new Date(System.currentTimeMillis() - 10L * 86_400_000L);
+
+        User user = freshUser(userId, familyId, "FREE", null);
+        // 仅存在一条历史已过期付费记录(PREMIUM)
+        FamilyMembership expired = activeMembership(familyId, "PREMIUM", "paid", past);
+
+        when(userMapper.selectById(userId)).thenReturn(user);
+        // 有效会员查询(getActiveFamilyMembership 带 endDate > now 过滤)→ SQL 层过滤掉过期记录 → null
+        when(membershipMapper.selectOne(any())).thenReturn(null);
+        // getLatestPaidFamilyMembership 走 List 查询(只按 paid 且倒序取最新,不要求未过期)→ 返回过期历史记录
+        when(membershipMapper.selectList(any())).thenReturn(Collections.singletonList(expired));
+        when(levelMapper.selectOne(any())).thenReturn(freshLevel("PREMIUM", 4));
+
+        AiGateResult result = service.checkAiFeatureGate(userId);
+
+        assertNotNull(result);
+        assertFalse(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] 过期会员(endDate 已回退)应 isActive=false,入口隐藏(AC-1b)");
+    }
+
+    /**
+     * AC-1c:从未付费(无有效记录、无历史付费)→ isActive=false。新用户或 FREE 用户一律不可见入口。
+     */
+    @Test
+    @DisplayName("AC-1c:未付费用户 → isActive=false(入口必隐藏)")
+    void ac1_neverPaid_isActiveFalse() {
+        long userId = 12L;
+        long familyId = 102L;
+
+        User user = freshUser(userId, familyId, "FREE", null);
+
+        when(userMapper.selectById(userId)).thenReturn(user);
+        when(membershipMapper.selectOne(any())).thenReturn(null);
+        when(membershipMapper.selectList(any())).thenReturn(Collections.emptyList());
+        when(levelMapper.selectOne(any())).thenReturn(freshLevel("FREE", 1));
+
+        AiGateResult result = service.checkAiFeatureGate(userId);
+
+        assertNotNull(result);
+        assertFalse(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] 未付费用户应 isActive=false(AC-1c)");
+    }
+
+    // =====================================================================
+    // AC-2 fail-closed:查不到 / 异常兜底
+    // =====================================================================
+
+    /**
+     * AC-2a:userId 直接为 null → fail-closed,结果中 isActive=false、status 不得是 ALLOW。
+     * 对应前端「无 token 直接 false(不发请求)」的契约;本测试用 service 直调验证后端同等行为。
+     */
+    @Test
+    @DisplayName("AC-2a:userId=null → fail-closed(isActive=false,status≠ALLOW)")
+    void ac2_nullUserId_failClosed() {
+        AiGateResult result = service.checkAiFeatureGate(null);
+
+        assertNotNull(result, "[chat.entry.memberGate] 必须返回结构体,禁止 null");
+        assertFalse(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] userId=null 时 fail-closed,isActive 应为 false");
+        assertNotNull(result.getStatus(),
+                "[chat.entry.memberGate] status 不应为 null(便于前端区分未认证 vs 其他状态)");
+    }
+
+    /**
+     * AC-2b:DB 抛出异常(查 User 失败)→ fail-closed,视为未激活。
+     */
+    @Test
+    @DisplayName("AC-2b:查 User 异常 → fail-closed(isActive=false)")
+    void ac2_userDbException_failClosed() {
+        long userId = 13L;
+
+        when(userMapper.selectById(userId)).thenThrow(new RuntimeException("DB down"));
+
+        AiGateResult result = service.checkAiFeatureGate(userId);
+
+        assertNotNull(result);
+        assertFalse(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] DB 异常时应 fail-closed,isActive=false(AC-2b)");
+    }
+
+    // =====================================================================
+    // AC-3 开关解耦:isActive 与门控开关独立
+    // =====================================================================
+
+    /**
+     * AC-3:运营开关关闭(member_gate_enabled=false)时,{@code isActive} 仍按真实付费记录计算;
+     * 有效付费用户仍应返回 {@code isActive=true}——堵住「开关关闭 → 误放行」的历史漏洞。
+     * 这是 S1-1 最核心的防漏条款。
+     */
+    @Test
+    @DisplayName("AC-3:开关关闭时有效付费会员仍 isActive=true(开关与 isActive 解耦)")
+    void ac3_gateDisabled_butActivePayment_stillActive() {
+        long userId = 14L;
+        long familyId = 104L;
+        Date farFuture = new Date(System.currentTimeMillis() + 40L * 86_400_000L);
+
+        // 网关关闭
+        when(sysConfigService.getValue(GATE_ENABLED_KEY)).thenReturn("false");
+        // 实际存在一条未来到期的家庭付费记录
+        User user = freshUser(userId, familyId, "FREE", null);
+        FamilyMembership fm = activeMembership(familyId, "FAMILY", "paid", farFuture);
+
+        when(userMapper.selectById(userId)).thenReturn(user);
+        when(membershipMapper.selectOne(any())).thenReturn(fm);
+        when(levelMapper.selectOne(any())).thenReturn(freshLevel("FAMILY", 3));
+
+        AiGateResult result = service.checkAiFeatureGate(userId);
+
+        assertNotNull(result);
+        assertFalse(result.isEnabled(),
+                "[chat.entry.memberGate] 开关应显示为关闭(enabled=false)——验证用例确实走了关门路径");
+        assertTrue(Boolean.TRUE.equals(result.getIsActive()),
+                "[chat.entry.memberGate] isActive 必须基于真实付费记录,不与成员开关联动(AC-3,堵历史漏洞)");
+    }
+
+    // =====================================================================
+    // 辅助方法
+    // =====================================================================
+
+    /** 通过反射将 field 的值注入 service 实例(同类于 MembershipViewScP59ContractTest 的做法) */
+    private static void inject(Object target, String fieldName, Object value) throws Exception {
+        Field f = target.getClass().getDeclaredField(fieldName);
+        f.setAccessible(true);
+        f.set(target, value);
+    }
+
+    /** 构建最小 User 实体 */
+    private User freshUser(long id, long familyId, String memberLevel, Date expireTime) {
+        User u = new User();
+        u.setId(id);
+        u.setFamilyId(familyId);
+        u.setMemberLevel(memberLevel);
+        u.setMemberExpireTime(expireTime);
+        return u;
+    }
+
+    /** 构建一条有效的家庭会员记录 */
+    private FamilyMembership activeMembership(long familyId, String levelCode,
+                                               String paymentStatus, Date endDate) {
+        FamilyMembership m = new FamilyMembership();
+        m.setId(1L);
+        m.setFamilyId(familyId);
+        m.setLevelCode(levelCode);
+        m.setPaymentStatus(paymentStatus);
+        m.setStartDate(new Date(System.currentTimeMillis() - 30L * 86_400_000L));
+        m.setEndDate(endDate);
+        return m;
+    }
+
+    /** 构建一个 MembershipLevel 用于映射等级顺序 */
+    private MembershipLevel freshLevel(String code, int order) {
+        MembershipLevel l = new MembershipLevel();
+        l.setId((long) order);
+        l.setLevelCode(code);
+        l.setLevelOrder(order);
+        return l;
+    }
+}