Просмотр исходного кода

test(cfc-backend): S-cfc-399 契约测试 cf.rewardv2.removeLegacy 旧体系废弃清理(TDD RED)

Administrator 1 день назад
Родитель
Сommit
199dbbd3f5

+ 236 - 0
cfc-backend/src/test/java/com/etotem/cfc/unit/RewardV2RemoveLegacyContractTest.java

@@ -0,0 +1,236 @@
+package com.etotem.cfc.unit;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.io.File;
+import java.io.InputStream;
+import java.lang.reflect.Field;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.util.Scanner;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * 契约级单测:旧体系废弃清理(能力键 {@code cf.rewardv2.removeLegacy},设计文档 §6 T07)。
+ *
+ * <p>契约来源(2026-11-14-cf-reward-model-v2-design.md §6 T07 + §8 用例#11):
+ * <blockquote>
+ *   T07 旧体系废弃清理:删除调用点(5处)+CronTask+AdminController+服务类,4 旧表归档只读、验证不再新增;
+ *   §8 用例#11:调用点已删、TeamProfitCronTask 已删,profit_pool_order 不再新增;4 旧表数据完整保留可查。
+ * </blockquote></p>
+ *
+ * <p><b>实现现状(src/main 核实)</b>:本分支 src/main 中旧「团队 8 份分润」体系<b>仍完整存在</b>——
+ * {@code ProfitPoolService} / {@code TeamProfitService} / {@code TeamProfitFlowService} /
+ * {@code StarScoreCalculator} 服务类与 {@code TeamProfitCronTask} / {@code TeamProfitAdminController}
+ * 均未删除;PaymentService/ProductOrderService/MembershipService/AssessmentOrderService/
+ * MemberSubscriptionService 5 个订单服务仍持有 {@code private ProfitPoolService profitPoolService;} 注入点;
+ * DatabaseInitializer 迁移 458/459/460/462 仍执行 4 旧表
+ * (profit_pool_order/team_share_record/team_award_record/service_cost_config)的 CREATE DDL。
+ * 因此本测试断言「废弃清理契约所需状态」全部不满足(红),失败断言原文清晰可贴。</p>
+ *
+ * <p><b>GREEN 升级指引</b>:实现者在 T07 落地后(删除 5 处调用点 + 删 CronTask/AdminController/服务类,
+ * 4 旧表转归档只读、不再新增)时,本测试自动转绿;届时可将结构探测升级为行为级
+ * mock 验证({@code verify(paymentService, never()).xxx()} 等)。</p>
+ *
+ * <p><b>权限流说明</b>:本能力为后端内部废弃清理(删除旧体系调用点/类/表 DDL),无用户权限维度,
+ * 「权限(适用时)」三流中的权限流不适用,以说明性用例标注。</p>
+ */
+class RewardV2RemoveLegacyContractTest {
+
+    /** 旧体系服务类(T07 删除对象的「服务类」部分,全库现状核实均存在) */
+    private static final String[] LEGACY_SERVICE_CLASSES = {
+            "com.etotem.cfc.service.ProfitPoolService",
+            "com.etotem.cfc.service.TeamProfitService",
+            "com.etotem.cfc.service.TeamProfitFlowService",
+            "com.etotem.cfc.service.StarScoreCalculator"
+    };
+
+    /** 旧体系定时任务 + 管理端(T07 删除对象的 CronTask/AdminController 部分) */
+    private static final String[] LEGACY_SCHEDULER_CONTROLLER_CLASSES = {
+            "com.etotem.cfc.task.TeamProfitCronTask",
+            "com.etotem.cfc.controller.admin.TeamProfitAdminController"
+    };
+
+    /** 5 处调用点所在的订单服务类(现状均持有 ProfitPoolService 注入字段) */
+    private static final String[] ORDER_SERVICES = {
+            "com.etotem.cfc.service.PaymentService",
+            "com.etotem.cfc.service.ProductOrderService",
+            "com.etotem.cfc.service.MembershipService",
+            "com.etotem.cfc.service.AssessmentOrderService",
+            "com.etotem.cfc.service.MemberSubscriptionService"
+    };
+
+    /** 旧体系 4 表(§3.4/T07 归档对象,现状 DatabaseInitializer 迁移 458/459/460/462 仍在创建) */
+    private static final String[] LEGACY_TABLES = {
+            "profit_pool_order",
+            "team_share_record",
+            "team_award_record",
+            "service_cost_config"
+    };
+
+    // ------------------------------------------------------------------
+    // 正常流:5 处调用点 + 旧体系服务类应已删除(T07「删除调用点(5处)+服务类」)
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("正常流-1:5 处订单服务调用点应已删除(不再注入 ProfitPoolService)")
+    void orderServices_callPointsRemoved() {
+        for (String svc : ORDER_SERVICES) {
+            Class<?> clazz = loadClass(svc);
+            boolean stillInjected = false;
+            if (clazz != null) {
+                for (Field f : clazz.getDeclaredFields()) {
+                    if ("com.etotem.cfc.service.ProfitPoolService".equals(f.getType().getName())) {
+                        stillInjected = true;
+                        break;
+                    }
+                }
+            }
+            assertFalse(stillInjected,
+                    "[cf.rewardv2.removeLegacy] " + simpleName(svc)
+                            + " 仍注入 ProfitPoolService:T07 契约要求删除 5 处旧体系调用点"
+                            + "(PaymentService/ProductOrderService/MembershipService/"
+                            + "AssessmentOrderService/MemberSubscriptionService),实现未落地(红)。");
+        }
+    }
+
+    @Test
+    @DisplayName("正常流-2:旧体系服务类应已删除(ProfitPoolService/TeamProfitService/FlowService/StarScoreCalculator)")
+    void legacyServiceClasses_removed() {
+        for (String fqcn : LEGACY_SERVICE_CLASSES) {
+            assertClassRemoved(fqcn, "T07 契约要求删除旧体系『服务类』(§6 T07)");
+        }
+    }
+
+    @Test
+    @DisplayName("正常流-3:TeamProfitCronTask 与 TeamProfitAdminController 应已删除")
+    void legacySchedulerAndController_removed() {
+        for (String fqcn : LEGACY_SCHEDULER_CONTROLLER_CLASSES) {
+            assertClassRemoved(fqcn, "T07 契约要求删除旧体系 CronTask 与 AdminController(§6 T07)");
+        }
+    }
+
+    // ------------------------------------------------------------------
+    // 边界流:4 旧表归档只读、验证不再新增(T07「4旧表归档只读」「profit_pool_order 不再新增」)
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("边界流-1:DatabaseInitializer 不应再执行 4 旧表 CREATE DDL(不再新增)")
+    void databaseInitializer_noLegacyTableCreateDdl() {
+        String source = readDatabaseInitializerSource();
+        assertFalse(source.isEmpty(),
+                "[cf.rewardv2.removeLegacy] 无法读取 DatabaseInitializer.java 源码,无法验证建表 DDL 移除情况。");
+        for (String table : LEGACY_TABLES) {
+            assertFalse(source.contains("CREATE TABLE IF NOT EXISTS " + table),
+                    "[cf.rewardv2.removeLegacy] DatabaseInitializer 仍执行 " + table
+                            + " 的 CREATE TABLE DDL(对旧体系可写建表路径未拆除);T07 契约要求"
+                            + " 4 旧表归档只读、验证不再新增(§6 T07 / §8 用例#11)。实现未落地(红)。");
+        }
+    }
+
+    @Test
+    @DisplayName("边界流-2:schema.sql 应保留 4 旧表定义(数据完整保留可查)")
+    void schemaSql_legacyTablesDataPreserved() {
+        String schema = readSchemaSql();
+        for (String table : LEGACY_TABLES) {
+            assertTrue(schema.contains(table),
+                    "[cf.rewardv2.removeLegacy] schema.sql 缺少 " + table
+                            + " 归档定义:T07 契约要求 4 旧表『数据完整保留可查』(§8 用例#11)。");
+        }
+    }
+
+    // ------------------------------------------------------------------
+    // 权限流(不适用):后端内部废弃清理,无用户权限维度
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("权限流:本能力为后端内部废弃清理,无用户权限维度,权限流不适用")
+    void permissionFlow_notApplicable() {
+        // 说明性用例:契约 AC 为「删除旧体系调用点/类/表 DDL」的内部清理动作,无权限校验维度。
+        // 不产生断言失败;仅为三流覆盖标注「不适用」。
+        assertTrue(true, "权限流不适用:cf.rewardv2.removeLegacy 为后端内部废弃清理,无用户权限维度。");
+    }
+
+    // ------------------------------------------------------------------
+    // 反射/文件辅助
+    // ------------------------------------------------------------------
+
+    private void assertClassRemoved(String fqcn, String reason) {
+        boolean stillExists = loadClass(fqcn) != null;
+        assertFalse(stillExists,
+                "[cf.rewardv2.removeLegacy] " + fqcn + " 仍存在:" + reason
+                        + "。实现未落地(红)。");
+    }
+
+    private Class<?> loadClass(String name) {
+        try {
+            return Class.forName(name, false, Thread.currentThread().getContextClassLoader());
+        } catch (ClassNotFoundException e) {
+            return null;
+        }
+    }
+
+    private String simpleName(String fqcn) {
+        int idx = fqcn.lastIndexOf('.');
+        return idx >= 0 ? fqcn.substring(idx + 1) : fqcn;
+    }
+
+    private String readSchemaSql() {
+        try (InputStream is = getClass().getClassLoader().getResourceAsStream("schema.sql")) {
+            if (is == null) {
+                return "";
+            }
+            try (Scanner scanner = new Scanner(is, StandardCharsets.UTF_8.name())) {
+                scanner.useDelimiter("\\A");
+                return scanner.hasNext() ? scanner.next() : "";
+            }
+        } catch (Exception e) {
+            return "";
+        }
+    }
+
+    private String readDatabaseInitializerSource() {
+        // 1) 从测试类落盘位置反推 cfc-backend 根目录再定位源码(mvn test 常用形态)
+        try {
+            java.net.URL res = getClass().getResource("RewardV2RemoveLegacyContractTest.class");
+            if (res != null) {
+                File dir = new File(res.toURI()).getParentFile(); // .../target/test-classes/com/etotem/cfc/unit
+                // 向上走到含 src/main/java/.../DatabaseInitializer.java 的目录(即 cfc-backend 根)
+                for (int i = 0; i < 8 && dir != null; i++) {
+                    File candidate = new File(dir,
+                            "src/main/java/com/etotem/cfc/config/DatabaseInitializer.java");
+                    if (candidate.exists()) {
+                        return readFileText(candidate.getAbsolutePath());
+                    }
+                    dir = dir.getParentFile();
+                }
+            }
+        } catch (Exception ignored) {
+            // 尝试候选 2
+        }
+        // 2) 从工作目录定位(cwd = cfc-backend 或仓库根)
+        String[] candidates = {
+                "src/main/java/com/etotem/cfc/config/DatabaseInitializer.java",
+                "cfc-backend/src/main/java/com/etotem/cfc/config/DatabaseInitializer.java"
+        };
+        for (String rel : candidates) {
+            File f = new File(rel);
+            if (f.exists()) {
+                return readFileText(f.getAbsolutePath());
+            }
+        }
+        return "";
+    }
+
+    private String readFileText(String absPath) {
+        try {
+            return new String(Files.readAllBytes(Paths.get(absPath)), StandardCharsets.UTF_8);
+        } catch (Exception e) {
+            return "";
+        }
+    }
+}