Forráskód Böngészése

test(S-cfc-282): RED contract test for plan.task.list (SC-P-47 GrowthPlanService#planTaskList / GrowthPlanController#planTasks)

E2E Test Bot 3 napja
szülő
commit
1f223f4ade

+ 378 - 0
cfc-backend/src/test/java/com/etotem/cfc/unit/PlanTaskListContractTest.java

@@ -0,0 +1,378 @@
+package com.etotem.cfc.unit;
+
+import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
+import com.baomidou.mybatisplus.core.MybatisConfiguration;
+import com.baomidou.mybatisplus.core.metadata.TableInfoHelper;
+import com.etotem.cfc.common.Result;
+import com.etotem.cfc.controller.growth.GrowthPlanController;
+import com.etotem.cfc.entity.GrowthPlan;
+import com.etotem.cfc.entity.Task;
+import com.etotem.cfc.mapper.GrowthPlanMapper;
+import com.etotem.cfc.mapper.TaskMapper;
+import com.etotem.cfc.service.GrowthPlanService;
+import org.apache.ibatis.builder.MapperBuilderAssistant;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentCaptor;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.*;
+import static org.mockito.ArgumentMatchers.isNull;
+
+/**
+ * 契约级单测:能力键 {@code plan.task.list} (SC-P-47 查看方案下任务列表)。
+ *
+ * <p>需求溯源:tests/user-scenarios/应用场景总览.md SC-P-47(方案关联任务列表(状态/进度),
+ * 任务增删与方案同步);设计溯源:docs/superpowers/api/API_REFERENCE.md §4.3 任务。
+ * 模块:{@code GrowthPlanController} + {@code TaskController}。</p>
+ *
+ * <p>与 task.parent.createTask/task.parent.review (S-cfc-12/13) 区分:
+ * task.* 是通用任务视图(锚点 memberId:/api/tasks/history、/today-parent、/my-pending);
+ * plan.task.list 是<b>方案维度</b>的任务清单视图(锚点 planId,按 source_type='plan' AND source_id=planId 过滤)。</p>
+ *
+ * <p>参考先例(同库同形态,已落地):{@code HealthPlanController.planTasks}(POST /api/health/plan/tasks,
+ * body {planId},familyId guard,错误文案「planId不能为空」/「方案不存在」/「无权查看该方案任务」)。
+ * 本能力在<b>成长方案</b>(GrowthPlan)侧缺失同形态端点,需补齐。</p>
+ *
+ * <p><b>契约宿主</b>(TDD-RED 锚点):
+ * <ul>
+ *   <li>{@code GrowthPlanService#planTaskList(Long planId)} —— 方案维度任务清单,返回 {@code List<Task>}
+ *       (source_type='plan' AND source_id=planId,逐项携带 status,进度载体由 Task.progress/todayDone 回填)</li>
+ *   <li>{@code GrowthPlanController#planTasks(Map<String, Object> params)} —— POST /api/growth/plan/tasks,
+ *       body {planId};planId 缺失 → Result.error("planId不能为空");方案不存在 → Result.error("方案不存在");
+ *       成功 → Result.success(growthPlanService.planTaskList(planId))</li>
+ * </ul></p>
+ *
+ * <p><b>实现现状</b>(本分支 src/main 核实):{@code GrowthPlanService} 仅有 {@code getProgress(Long, Long)}
+ * 返回聚合 VO(completedTasks/totalTasks/progressPercent,无任务明细列表);
+ * {@code GrowthPlanController} 无 tasks 端点。契约方法/端点均未落地,故本测试以「反射探测宿主契约方法」
+ * 断言缺失:能编译、能运行、断言失败(红),失败断言原文清晰可贴。</p>
+ *
+ * <p><b>GREEN 升级指引</b>:实现 {@code GrowthPlanService.planTaskList(Long planId)}
+ * (LambdaQueryWrapper: eq(sourceType,"plan").eq(sourceId, planId),任务增删同步=实时查询不缓存)
+ * 与 {@code GrowthPlanController.planTasks(Map)}(委托 Service)后,本测试自动转绿。</p>
+ *
+ * <p><b>权限流说明</b>:/api/growth/plan/* 由 JwtInterceptor 统一拦截(非公开路径),端点继承登录态鉴权;
+ * 本类权限流聚焦「方案维度视图 vs 通用任务视图」的口径区分,并对现状(聚合 VO 不含明细)做观测钉住。</p>
+ *
+ * <p><b>测试范围</b>:纯 Mockito/反射,无 Spring / 无 DB / 无真实微信 / 无外部服务。</p>
+ */
+class PlanTaskListContractTest {
+
+    private static final String HOST_SERVICE = "com.etotem.cfc.service.GrowthPlanService";
+    private static final String HOST_CONTROLLER = "com.etotem.cfc.controller.growth.GrowthPlanController";
+    private static final Long PLAN_ID = 282L;
+
+    @Mock
+    private GrowthPlanMapper growthPlanMapper;
+
+    @Mock
+    private TaskMapper taskMapper;
+
+    @InjectMocks
+    private GrowthPlanService service;
+
+    @BeforeEach
+    void setUp() throws Exception {
+        MockitoAnnotations.openMocks(this);
+        inject(service, "growthPlanMapper", growthPlanMapper);
+        inject(service, "taskMapper", taskMapper);
+        // 初始化 Task 的 lambda 缓存,使 LambdaQueryWrapper.getParamNameValuePairs() 能填充参数值
+        TableInfoHelper.initTableInfo(new MapperBuilderAssistant(new MybatisConfiguration(), ""), Task.class);
+    }
+
+    // ==================== 反射辅助(锚定宿主契约,避免编译期依赖不存在的方法) ====================
+
+    private void inject(Object target, String field, Object value) throws Exception {
+        Field f = target.getClass().getDeclaredField(field);
+        f.setAccessible(true);
+        f.set(target, value);
+    }
+
+    /** 按方法名 + 参数个数匹配;契约方法缺失即断言失败(RED)。 */
+    private Object invoke(Object host, String method, Object... args) {
+        for (Method m : host.getClass().getMethods()) {
+            if (m.getName().equals(method) && m.getParameterCount() == args.length) {
+                try {
+                    m.setAccessible(true);
+                    return m.invoke(host, args);
+                } catch (Exception e) {
+                    fail("契约方法 " + host.getClass().getSimpleName() + "#" + method + " 调用失败:" + e.getMessage());
+                    return null;
+                }
+            }
+        }
+        fail("RED[plan.task.list] 契约宿主 " + HOST_SERVICE + "/" + HOST_CONTROLLER
+                + "#" + method + " 未实现(实现未落地):" + method + " 方法不存在。");
+        return null;
+    }
+
+    /** 按方法名匹配(忽略参数个数),返回匹配的第一个方法或 null。 */
+    private Method methodOf(Object host, String name) {
+        for (Method m : host.getClass().getMethods()) {
+            if (m.getName().equals(name)) {
+                return m;
+            }
+        }
+        for (Method m : host.getClass().getDeclaredMethods()) {
+            if (m.getName().equals(name)) {
+                return m;
+            }
+        }
+        return null;
+    }
+
+    @SuppressWarnings("unchecked")
+    private List<Task> invokeList(Object host, String method, Object... args) {
+        Object r = invoke(host, method, args);
+        if (r instanceof List) {
+            return (List<Task>) r;
+        }
+        fail("契约方法 " + method + " 应返回 List<Task>,实际 " + r);
+        return Collections.emptyList();
+    }
+
+    private GrowthPlan plan(Long id, String status) {
+        GrowthPlan p = new GrowthPlan();
+        p.setId(id);
+        p.setStatus(status);
+        p.setPlanTitle("契约测试方案");
+        p.setCreatedAt(new Date());
+        p.setUpdatedAt(new Date());
+        return p;
+    }
+
+    private Task planTask(Long id, String status, Long sourceId) {
+        Task t = new Task();
+        t.setId(id);
+        t.setSourceType("plan");
+        t.setSourceId(sourceId);
+        t.setStatus(status);
+        t.setTitle("方案任务-" + id);
+        return t;
+    }
+
+    private GrowthPlanController controllerWithService() throws Exception {
+        GrowthPlanController c = new GrowthPlanController();
+        inject(c, "growthPlanService", service);
+        inject(c, "userMapper", mock(com.etotem.cfc.mapper.UserMapper.class));
+        inject(c, "growthPlanMapper", growthPlanMapper);
+        return c;
+    }
+
+    private Map<String, Object> body(Object planId) {
+        Map<String, Object> m = new HashMap<>();
+        if (planId != null) {
+            m.put("planId", planId);
+        }
+        return m;
+    }
+
+    // ==================== 正常流 ====================
+
+    @Test
+    @DisplayName("正常流-1:GrowthPlanService 应提供 planTaskList(Long planId) 契约方法(方案维度任务清单)")
+    void service_planTaskList_methodExists() {
+        GrowthPlanService svc = new GrowthPlanService();
+        Method m = methodOf(svc, "planTaskList");
+        assertNotNull(m,
+                "RED[plan.task.list] GrowthPlanService 应提供 planTaskList(Long planId) 契约方法"
+                        + "(方案维度任务清单),实现未落地:当前仅有 getProgress 聚合统计,无任务明细视图。");
+        assertEquals(1, m.getParameterCount(),
+                "planTaskList 应以 planId 为唯一过滤锚点(方案维度,区别于按 memberId 的通用任务视图)。");
+        assertEquals(Long.class, m.getParameterTypes()[0], "planId 参数类型应为 Long。");
+    }
+
+    @Test
+    @DisplayName("正常流-2:planTaskList 应返回方案下任务明细列表(source_type='plan' & source_id=planId)")
+    void planTaskList_returnsPlanTaskDetailList() {
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(plan(PLAN_ID, "active"));
+        List<Task> seeded = new ArrayList<>();
+        seeded.add(planTask(1L, "pending", PLAN_ID));
+        seeded.add(planTask(2L, "completed", PLAN_ID));
+        when(taskMapper.selectList(any())).thenReturn(seeded);
+
+        List<Task> result = invokeList(service, "planTaskList", PLAN_ID);
+
+        assertNotNull(result, "应返回方案任务明细列表(非聚合 VO)");
+        assertEquals(2, result.size(), "应返回方案下全部任务明细");
+        assertEquals(1L, result.get(0).getId().longValue(), "明细项应保留任务 ID");
+    }
+
+    @Test
+    @DisplayName("正常流-3:planTaskList 每项应携带状态;进度载体由 Task.progress/todayDone 回填(实体契约观察)")
+    void planTaskList_eachTaskCarriesStatus() {
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(plan(PLAN_ID, "active"));
+        Task t1 = planTask(1L, "pending", PLAN_ID);
+        t1.setProgress(50);
+        t1.setTodayDone(1);
+        Task t2 = planTask(2L, "completed", PLAN_ID);
+        when(taskMapper.selectList(any())).thenReturn(new ArrayList<>(Arrays.asList(t1, t2)));
+
+        List<Task> result = invokeList(service, "planTaskList", PLAN_ID);
+
+        assertNotNull(result.get(0).getStatus(), "列表每项应携带 status(状态);RED[plan.task.list] 宿主未实现。");
+        assertEquals("completed", result.get(1).getStatus());
+        // 进度载体观察:Task 实体已提供 progress/todayDone 非持久化字段(@TableField(exist=false)),
+        // 方案任务清单视图可据此回填进度型任务(is_daily_progress=1)的进度。
+        boolean hasProgressCarrier = false;
+        for (java.lang.reflect.Field f : Task.class.getDeclaredFields()) {
+            if ("progress".equals(f.getName()) || "todayDone".equals(f.getName())) {
+                hasProgressCarrier = true;
+                break;
+            }
+        }
+        assertTrue(hasProgressCarrier, "Task 实体应暴露 progress/todayDone 进度载体字段(方案任务清单视图可回填)。");
+    }
+
+    @Test
+    @DisplayName("正常流-4:GrowthPlanController 应暴露 planTasks(POST /api/growth/plan/tasks)端点")
+    void controller_planTasks_methodExists() throws Exception {
+        GrowthPlanController c = controllerWithService();
+        Method m = methodOf(c, "planTasks");
+        assertNotNull(m,
+                "RED[plan.task.list] GrowthPlanController 应暴露 planTasks(POST /api/growth/plan/tasks)端点"
+                        + "(方案维度任务清单),实现未落地。参考先例:HealthPlanController.planTasks。");
+    }
+
+    @Test
+    @DisplayName("正常流-5:planTasks 端点应委托 growthPlanService 查询方案任务(端到端到 taskMapper)")
+    void controller_planTasks_delegatesToService() throws Exception {
+        GrowthPlanController c = controllerWithService();
+        // 真实注入的 service(@InjectMocks)+ growthPlanMapper/taskMapper mock:
+        // 契约兑现后 端点→service→taskMapper 全链路贯通,此处可红可绿按宿主现状断言。
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(plan(PLAN_ID, "active"));
+        List<Task> seeded = new ArrayList<>();
+        seeded.add(planTask(1L, "pending", PLAN_ID));
+        when(taskMapper.selectList(any())).thenReturn(seeded);
+
+        Result<List<Task>> r = (Result<List<Task>>) invoke(c, "planTasks", body(PLAN_ID));
+
+        assertEquals(200, r.getCode(), "正常流应 200");
+        assertNotNull(r.getData(), "应返回方案任务列表");
+        assertEquals(1, r.getData().size());
+        // 端到端:Controller 委托 service → service 走 taskMapper 查询(非 controller 直接操作 mapper,分层合规)
+        verify(taskMapper).selectList(any());
+    }
+
+    // ==================== 边界流 ====================
+
+    @Test
+    @DisplayName("边界流-1:planId 缺失 → 端点返回业务错误提示「planId不能为空」")
+    void controller_planTasks_planIdMissing_returnsError() throws Exception {
+        GrowthPlanController c = controllerWithService();
+
+        Result<?> r = (Result<?>) invoke(c, "planTasks", body(null));
+
+        assertEquals(500, r.getCode(), "planId 缺失应业务错误(Result.error → 500,非 200)");
+        assertEquals("planId不能为空", r.getMessage());
+    }
+
+    @Test
+    @DisplayName("边界流-2:方案不存在 → 端点返回业务错误提示「方案不存在」")
+    void controller_planTasks_planNotExists_returnsError() throws Exception {
+        GrowthPlanController c = controllerWithService();
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(null);
+
+        Result<?> r = (Result<?>) invoke(c, "planTasks", body(PLAN_ID));
+
+        assertEquals(500, r.getCode(), "方案不存在应业务错误(Result.error → 500,非 200)");
+        assertEquals("方案不存在", r.getMessage());
+    }
+
+    @Test
+    @DisplayName("边界流-3:任务增删与方案同步——列表实时反映最新任务集(两次调用无缓存)")
+    void planTaskList_taskAddDelete_syncsWithPlan() {
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(plan(PLAN_ID, "active"));
+        Task t1 = planTask(1L, "pending", PLAN_ID);
+        Task t2 = planTask(2L, "completed", PLAN_ID);
+        // 模拟任务增删同步:第一次 2 条,删除后第二次 1 条
+        when(taskMapper.selectList(any()))
+                .thenReturn(new ArrayList<>(Arrays.asList(t1, t2)))
+                .thenReturn(new ArrayList<>(Collections.singletonList(t2)));
+
+        List<Task> first = invokeList(service, "planTaskList", PLAN_ID);
+        List<Task> second = invokeList(service, "planTaskList", PLAN_ID);
+
+        assertEquals(2, first.size(), "任务增删前应返回 2 条");
+        assertEquals(1, second.size(), "任务删除后应实时反映为 1 条(无缓存,同步方案任务集)");
+        verify(taskMapper, times(2)).selectList(any());
+    }
+
+    @Test
+    @DisplayName("边界流-4:planId 为 null 安全默认(不 NPE,返回空列表)")
+    void planTaskList_planIdNull_returnsEmptySafeDefault() {
+        // 不 stub 任何 mapper(若实现误查询非 null 条件会触发未 stub 返回 null/空)
+        when(growthPlanMapper.selectById(isNull())).thenReturn(null);
+
+        List<Task> result = invokeList(service, "planTaskList", new Object[]{null});
+
+        assertNotNull(result, "planId 为 null 应返回空列表而非 null(安全默认)");
+        assertTrue(result.isEmpty(), "planId 为 null 应返回空列表(无方案锚点无明细)");
+    }
+
+    @Test
+    @DisplayName("边界流-5:方案任务清单查询应以 source_type='plan' AND source_id=planId 过滤(方案维度隔离)")
+    void planTaskList_queryScoped_planSourceTypeAndPlanId() {
+        when(growthPlanMapper.selectById(PLAN_ID)).thenReturn(plan(PLAN_ID, "active"));
+        when(taskMapper.selectList(any()))
+                .thenReturn(new ArrayList<>(Collections.singletonList(planTask(1L, "pending", PLAN_ID))));
+
+        invokeList(service, "planTaskList", PLAN_ID);
+
+        ArgumentCaptor<LambdaQueryWrapper<Task>> captor = ArgumentCaptor.forClass(LambdaQueryWrapper.class);
+        verify(taskMapper).selectList(captor.capture());
+        LambdaQueryWrapper<Task> wrapper = captor.getValue();
+        wrapper.getSqlSegment(); // 触发参数绑定到 paramNameValuePairs
+        Map<String, Object> params = wrapper.getParamNameValuePairs();
+        assertTrue(params.containsValue("plan"),
+                "查询应以 source_type='plan' 过滤(方案维度),实际参数:" + params);
+        assertTrue(params.containsValue(PLAN_ID),
+                "查询应以 source_id=planId 过滤(区别于按 memberId 的通用任务视图),实际参数:" + params);
+    }
+
+    // ==================== 权限流 ====================
+
+    @Test
+    @DisplayName("权限流-1:plan.task.list 为方案维度清单,区别于 task.* 通用视图;现有 getProgress 仅聚合(观测钉住)")
+    void permissionFlow_distinctFromGenericTaskViews() throws Exception {
+        GrowthPlanService svc = new GrowthPlanService();
+        // ① 契约口径:方案维度任务「清单」需 planTaskList 明细视图承载(按 planId 锚定)→ 主契约方法缺失(RED)
+        Method detail = methodOf(svc, "planTaskList");
+        assertNotNull(detail,
+                "RED[plan.task.list] 方案维度任务清单视图 planTaskList 未落地:应挂 GrowthPlanService"
+                        + "(按 planId 锚定),区别于按 memberId 的通用任务视图(/api/tasks/history、/today-parent、/my-pending)。");
+
+        // ② 现状观测钉住:getProgress(现有)仅返回聚合 VO(completedTasks/totalTasks/progressPercent),
+        //    不含任务明细列表字段 —— 聚合≠清单,明细需 planTaskList 独立承载,二者分工:聚合=进度卡,明细=清单视图。
+        Method agg = svc.getClass().getDeclaredMethod("getProgress", Long.class, Long.class);
+        assertEquals("GrowthPlanProgressVO", agg.getReturnType().getSimpleName(),
+                "观测钉住:现有 getProgress 返回聚合 VO,不承载任务明细(契约缺口,明细需 planTaskList 独立提供)。");
+        Class<?> voClass = Class.forName("com.etotem.cfc.dto.GrowthPlanProgressVO");
+        boolean hasListField = false;
+        for (java.lang.reflect.Field f : voClass.getDeclaredFields()) {
+            if (List.class.isAssignableFrom(f.getType())) {
+                hasListField = true;
+                break;
+            }
+        }
+        assertFalse(hasListField,
+                "观测钉住:getProgress 聚合 VO 不含 List<Task> 明细字段(聚合≠清单,契约缺口);"
+                        + "方案任务清单视图需 planTaskList 独立承载。");
+    }
+}