Procházet zdrojové kódy

Merge branch 'task/S-cfc-187' into cfclub

Sisyphus Agent před 1 týdnem
rodič
revize
233d6e7c0

+ 204 - 0
cfc-backend/src/test/java/com/etotem/cfc/unit/GuideFamilyTaskReviewContractTest.java

@@ -0,0 +1,204 @@
+package com.etotem.cfc.unit;
+
+import com.etotem.cfc.common.Result;
+import com.etotem.cfc.controller.guide.GuideFamilyTaskController;
+import com.etotem.cfc.dto.TaskReviewDTO;
+import com.etotem.cfc.entity.Task;
+import com.etotem.cfc.mapper.FamilyMemberMapper;
+import com.etotem.cfc.mapper.TaskMapper;
+import com.etotem.cfc.mapper.UserMapper;
+import com.etotem.cfc.service.GuideFamilyAccessGuard;
+import com.etotem.cfc.service.GuideFamilyService;
+import com.etotem.cfc.service.MembershipService;
+import com.etotem.cfc.service.RewardRuleService;
+import com.etotem.cfc.service.TaskService;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+
+import java.util.*;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.ArgumentMatchers.anyLong;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+
+/**
+ * 契约测试:能力键 {@code teacher.task.review}(SC-T-06 家庭任务审核 / SC-T-18 批量任务下发)。
+ *
+ * <p>锚点:
+ * <ul>
+ *   <li>契约文档 docs/superpowers/specs/2026-11-07-planner-zone-contract.md EVD-10 §2 SC-T-06/18 端点核验表;</li>
+ *   <li>派生用例 tests/test-cases/teacher.md TC-T-09(任务审核:通过给分/驳回重做/<b>越权非绑定家庭被拒</b>/并发双审幂等/超期被拒)
+ *       与 TC-T-18(批量任务:部分失败不影响其他/各自独立落库)、TC-T-09-P(权限流:非绑定家庭数据统一 403)。</li>
+ * </ul></p>
+ *
+ * <p><b>本类聚焦规划师(teacher)侧 {@link GuideFamilyTaskController} 的任务审核归属校验缺口</b>:
+ * 现有实现 {@code reviewTask} / {@code batchReviewTasks} 仅校验「规划师与 familyId 绑定」(requireBound)
+ * 与「任务存在+会员任务校验」(checkMemberOnly),<b>未校验被审任务 task.getFamilyId() 是否等于路径 familyId</b>——
+ * 对比同控制器 {@code updateTask} / {@code deleteTask} 已含「任务不属于该家庭」归属校验。该缺口使
+ * 已绑定家庭 A 的规划师传入属于家庭 B 的 taskId 即可跨家庭越权审核(IDOR),违反 TC-T-09-P
+ * 「非绑定家庭数据统一 403」。</p>
+ *
+ * <p><b>RED 预期</b>:跨家庭任务审核(reviewTask / batchReviewTasks)应被拒且不进入 taskService.reviewTask;
+ * 当前实现缺归属校验 → 会调用 taskService.reviewTask → 断言失败(红)。GREEN 阶段补归属校验后转绿。</p>
+ *
+ * <p>纯 Mockito(无 Spring / 无 DB / 无外部服务),参照同批 RED 契约测试风格(FamilyJoinValidationRulesContractTest、TeamProfitHookContractTest)。</p>
+ */
+class GuideFamilyTaskReviewContractTest {
+
+    private static final Long GUIDE_ID = 1L;
+    /** 规划师已绑定的家庭 ID(requireBound 放行来源) */
+    private static final Long BOUND_FAMILY_ID = 100L;
+    /** 非绑定的其他家庭 ID(跨家庭越权来源) */
+    private static final Long OTHER_FAMILY_ID = 999L;
+
+    @Mock
+    private TaskService taskService;
+
+    @Mock
+    private FamilyMemberMapper familyMemberMapper;
+
+    @Mock
+    private TaskMapper taskMapper;
+
+    @Mock
+    private UserMapper userMapper;
+
+    @Mock
+    private MembershipService membershipService;
+
+    @Mock
+    private GuideFamilyService guideFamilyService;
+
+    @Mock
+    private RewardRuleService rewardRuleService;
+
+    @Mock
+    private GuideFamilyAccessGuard guideFamilyAccessGuard;
+
+    @InjectMocks
+    private GuideFamilyTaskController controller;
+
+    @BeforeEach
+    void setUp() {
+        MockitoAnnotations.openMocks(this);
+        // 规划师与 BOUND_FAMILY_ID 已绑定 → requireBound 放行(检查绑定关系返回 null 表示放行)
+        when(guideFamilyAccessGuard.checkBinding(GUIDE_ID, BOUND_FAMILY_ID)).thenReturn(null);
+    }
+
+    // ==================== 正常流(对照,应全绿) ====================
+
+    /**
+     * 本家庭任务审核:task.familyId == familyId 路径一致,应调用 taskService.reviewTask 进入审核逻辑。
+     */
+    @Test
+    void reviewTask_本家庭任务_进入审核_返回通过() {
+        Long taskId = 5L;
+        when(taskMapper.selectById(taskId)).thenReturn(task(taskId, BOUND_FAMILY_ID, "pending_review"));
+        when(taskService.reviewTask(eq(taskId), any(TaskReviewDTO.class))).thenReturn(true);
+
+        Result<Boolean> result = controller.reviewTask(GUIDE_ID, BOUND_FAMILY_ID, taskId, "teacher", dto(true), null);
+
+        assertTrue(result.getData());
+        verify(taskService).reviewTask(eq(taskId), any(TaskReviewDTO.class));
+    }
+
+    // ==================== 权限流(RED 契约缺口) ====================
+
+    /**
+     * SC-T-06 / TC-T-09-P:规划师越权审核不属于已绑定家庭的子任务 —— 接口应拒绝且不进入 taskService.reviewTask。
+     *
+     * <p>缺口定位:{@code GuideFamilyTaskController#reviewTask} 当前不校验 {@code task.getFamilyId() == familyId},
+     * 导致任何已认证规划师传入跨家庭的 taskId 均可越权审核。</p>
+     */
+    @Test
+    void reviewTask_跨家庭任务_应拒绝且不进入审核() {
+        Long taskId = 5L;
+        // 任务存在,但其 familyId 与路径中的 BOUND_FAMILY_ID 不同(越权场景)
+        when(taskMapper.selectById(taskId)).thenReturn(task(taskId, OTHER_FAMILY_ID, "pending_review"));
+        when(taskService.reviewTask(eq(taskId), any(TaskReviewDTO.class))).thenReturn(true);
+
+        Result<Boolean> result = controller.reviewTask(GUIDE_ID, BOUND_FAMILY_ID, taskId, "teacher", dto(true), null);
+
+        // 契约:跨家庭任务不得进入审核逻辑(TC-T-09-P 非绑定家庭数据统一 403)
+        verify(taskService, never()).reviewTask(anyLong(), any(TaskReviewDTO.class));
+        assertNotEquals(Integer.valueOf(200), result.getCode(), "跨家庭任务审核应被拒(非 200 成功响应)");
+    }
+
+    /**
+     * SC-T-18 / TC-T-18-E:批量审核中包含跨家庭任务时,跨家任务应被跳过不被审核(各自独立不落库)。
+     *
+     * <p>当前实现循环 taskIds,每个 task 单独 checkMemberOnly + reviewTask;缺失跨家庭过滤 → 所有 task 均被处理。</p>
+     */
+    @Test
+    void batchReviewTasks_含跨家庭任务_应跳过跨家庭任务独立处理自身任务() {
+        Long ownTaskId = 1L;
+        Long crossTaskId = 2L;
+
+        when(taskMapper.selectById(ownTaskId)).thenReturn(task(ownTaskId, BOUND_FAMILY_ID, "pending_review"));
+        when(taskMapper.selectById(crossTaskId)).thenReturn(task(crossTaskId, OTHER_FAMILY_ID, "pending_review"));
+        when(taskService.reviewTask(anyLong(), any(TaskReviewDTO.class))).thenReturn(true);
+
+        Map<String, Object> params = new HashMap<>();
+        params.put("taskIds", Arrays.asList(ownTaskId, crossTaskId));
+        params.put("approved", true);
+
+        Result<Map<String, Object>> result = controller.batchReviewTasks(GUIDE_ID, BOUND_FAMILY_ID, "teacher", params, null);
+
+        // 契约:仅本家庭任务进入审核;跨家庭任务不得被审核(TC-T-18-E 部分失败不影响其他/TC-T-09-P 越权拒)
+        verify(taskService).reviewTask(eq(ownTaskId), any(TaskReviewDTO.class));
+        verify(taskService, never()).reviewTask(eq(crossTaskId), any(TaskReviewDTO.class));
+    }
+
+    // ==================== 角色校验(对照,应绿) ====================
+
+    /**
+     * 非 teacher/admin 角色访问规划师专属端点 → 应在 role 检查处短路返回 Access denied,不调 use Service。
+     */
+    @Test
+    void reviewTask_非teacher角色_拒绝且不进入审核() {
+        Long taskId = 5L;
+        Result<Boolean> result = controller.reviewTask(GUIDE_ID, BOUND_FAMILY_ID, taskId, "parent", dto(true), null);
+
+        assertEquals("Access denied", result.getMessage());
+        verify(taskService, never()).reviewTask(anyLong(), any(TaskReviewDTO.class));
+    }
+
+    @Test
+    void batchReviewTasks_非teacher角色_拒绝且不进入审核() {
+        Map<String, Object> params = new HashMap<>();
+        params.put("taskIds", Collections.singletonList(1L));
+        params.put("approved", true);
+        Result<Map<String, Object>> result = controller.batchReviewTasks(GUIDE_ID, BOUND_FAMILY_ID, "parent", params, null);
+
+        assertEquals("Access denied", result.getMessage());
+        verify(taskService, never()).reviewTask(anyLong(), any(TaskReviewDTO.class));
+    }
+
+    // ==================== 辅助 ====================
+
+    private Task task(Long id, Long familyId, String status) {
+        Task t = new Task();
+        t.setId(id);
+        t.setFamilyId(familyId);
+        t.setStatus(status);
+        t.setCompletedAt(new Date());
+        return t;
+    }
+
+    private TaskReviewDTO dto(boolean approved) {
+        TaskReviewDTO d = new TaskReviewDTO();
+        d.setApproved(approved);
+        d.setComment("契约测试审核");
+        return d;
+    }
+}