Prechádzať zdrojové kódy

test(RED): S-cfc-254 butler.quality.qa 服务质检与满意度 契约级单测 12例全红

新增 cfc-backend/src/test/java/com/etotem/cfc/unit/ButlerQualityQaContractTest.java

契约来源:tests/user-scenarios/应用场景总览.md SC-H-07(服务质检与满意度)
;API_REFERENCE ActivityFeedbackController + AdminSurveyController + 差评触发复盘/回流改进

RED 预期:但lerQualityService/ButlerSatisfactionService/ButlerPerformanceService 及 ButlerQualityInspection/ButlerSatisfaction 实体与 3 张建表均未落地,结构探测断言失败(11 例失败,权限流 1 例标注不适用),断言原文清晰可贴,待 GREEN 阶段实现后自动转绿。

禁止改 src/main 实现;仅新增测试文件。
Sisyphus 6 dní pred
rodič
commit
4ae83465b3

+ 283 - 0
cfc-backend/src/test/java/com/etotem/cfc/unit/ButlerQualityQaContractTest.java

@@ -0,0 +1,283 @@
+package com.etotem.cfc.unit;
+
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+
+import java.io.InputStream;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.nio.charset.StandardCharsets;
+import java.util.Scanner;
+
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * 契约级单测:真人管家服务质检与满意度(能力键 {@code butler.quality.qa})。
+ *
+ * <p>契约来源(tests/user-scenarios/应用场景总览.md SC-H-07;测试用例 {@code tests/test-cases/human-butler.md}
+ * TC-H-07;设计:{@code ActivityFeedbackController}(活动反馈,仅活动维度)+ {@code AdminSurveyController}
+ * (满意度调研模板)+ 差评触发复盘/回流改进):
+ * <blockquote>
+ *   流程:质检→满意度回访→回流改进。边界:不泄露隐私;差评触发复盘。
+ *   预期行为:
+ *   <ul>
+ *     <li>抽样/全量质检真人管家会话与工单(SLA、合规、态度),质检报告逐项给出通过/不通过与依据;</li>
+ *     <li>向家长发起满意度回访(问卷/评分),家长提交评分并成功;</li>
+ *     <li>质检结果回流至真人管家绩效看板,仅授权角色可见;</li>
+ *     <li>质检报告不展示家长隐私对话原文,仅展示脱敏摘要与判定依据;</li>
+ *     <li>差评自动触发复盘并关联 SC-H-04 升级应急流程;</li>
+ *     <li>同一家长重复提交评分以最后一次为准(幂等,不重复计数)。</li>
+ *   </ul>
+ * </blockquote></p>
+ *
+ * <p><b>实现现状</b>:本分支 src/main 中 {@code ButlerQualityService}、{@code ButlerSatisfactionService}、
+ * {@code ButlerPerformanceService} 及 {@code ButlerQualityInspection}/{@code ButlerSatisfaction} 实体与
+ * {@code butler_quality_inspections}/{@code butler_satisfaction}/{@code butler_performance} 表均未落地(schema.sql
+ * 无对应建表;{@code activity_feedback} 仅覆盖活动评价维度,不满足 butler 服务质检与满意度契约)。
+ * 因此本测试以「反射结构契约」探测实现缺失:能编译通过、能运行、断言失败(红),且失败断言原文
+ * 清晰可贴。</p>
+ *
+ * <p><b>GREEN 升级指引</b>:实现者创建 {@code ButlerQualityService}(含 {@code inspect} 质检入口与
+ * {@code triggerRetrospect} 差评复盘入口)、{@code ButlerSatisfactionService}(含 {@code submitSatisfaction}
+ * 评分提交入口)、{@code ButlerPerformanceService}(绩效看板入口)、相应实体与 3 张表、并在 schema.sql 同步
+ * 建表后,本测试自动转绿;届时可将结构探测升级为行为级 Mockito 验证({@code verify(...)})。</p>
+ *
+ * <p><b>权限流说明</b>:本能力为服务质检与满意度链路,绩效看板权限控制在 Controller 层;
+ * 「权限(适用时)」三流中的权限流以说明性用例标注。</p>
+ */
+class ButlerQualityQaContractTest {
+
+    /** 质检服务类(SC-H-07 质检→回流入口) */
+    private static final String BUTLER_QUALITY_SERVICE = "com.etotem.cfc.service.ButlerQualityService";
+
+    /** 满意度服务类(SC-H-07 满意度回访→评分提交入口) */
+    private static final String BUTLER_SATISFACTION_SERVICE = "com.etotem.cfc.service.ButlerSatisfactionService";
+
+    /** 管家绩效看板服务类(SC-H-07 结果回流入口) */
+    private static final String BUTLER_PERFORMANCE_SERVICE = "com.etotem.cfc.service.ButlerPerformanceService";
+
+    /** 质检记录实体(承载逐项 SLA/合规/态度 通过/不通过+依据) */
+    private static final String QUALITY_INSPECTION_ENTITY = "com.etotem.cfc.entity.ButlerQualityInspection";
+
+    /** 满意度评分实体(承载家长对管家服务的评分与差评触发标记) */
+    private static final String SATISFACTION_ENTITY = "com.etotem.cfc.entity.ButlerSatisfaction";
+
+    /** 质检/满意度/绩效建表(schema.sql 同步落地) */
+    private static final String[] QUALITY_TABLES = {
+            "butler_quality_inspections", "butler_satisfaction", "butler_performance"
+    };
+
+    // ------------------------------------------------------------------
+    // 正常流:质检服务类 + inspect 质检入口应存在
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("正常流-1:ButlerQualityService 质检服务类应存在")
+    void butlerQualityService_classExists() {
+        assertNotNull(loadClass(BUTLER_QUALITY_SERVICE),
+                "[butler.quality.qa] ButlerQualityService 类不存在:契约要求抽样/全量质检真人管家会话与工单"
+                        + "(SLA、合规、态度),逐项给出通过/不通过与依据(SC-H-07)。实现未落地。");
+    }
+
+    @Test
+    @DisplayName("正常流-2:ButlerQualityService 应提供 inspect 质检入口")
+    void butlerQualityService_hasInspectMethod() {
+        Class<?> clazz = loadClass(BUTLER_QUALITY_SERVICE);
+        if (clazz == null) {
+            fail("[butler.quality.qa] ButlerQualityService 类不存在,无法验证 inspect 质检入口(SC-H-07)。");
+        }
+        boolean hasInspect = false;
+        for (Method m : clazz.getDeclaredMethods()) {
+            if (m.getName().equals("inspect")) {
+                hasInspect = true;
+                break;
+            }
+        }
+        assertTrue(hasInspect,
+                "[butler.quality.qa] ButlerQualityService 应提供 inspect(...) 方法作为质检执行入口(SC-H-07)。");
+    }
+
+    @Test
+    @DisplayName("正常流-3:ButlerSatisfactionService 满意度服务类应存在")
+    void butlerSatisfactionService_classExists() {
+        assertNotNull(loadClass(BUTLER_SATISFACTION_SERVICE),
+                "[butler.quality.qa] ButlerSatisfactionService 类不存在:契约要求向家长发起满意度回访"
+                        + "(问卷/评分),家长提交评分并成功(SC-H-07)。实现未落地。");
+    }
+
+    @Test
+    @DisplayName("正常流-4:ButlerSatisfactionService 应提供 submitSatisfaction 评分提交入口")
+    void butlerSatisfactionService_hasSubmitSatisfactionMethod() {
+        Class<?> clazz = loadClass(BUTLER_SATISFACTION_SERVICE);
+        if (clazz == null) {
+            fail("[butler.quality.qa] ButlerSatisfactionService 类不存在,无法验证 submitSatisfaction 入口(SC-H-07)。");
+        }
+        boolean hasSubmitSatisfaction = false;
+        for (Method m : clazz.getDeclaredMethods()) {
+            if (m.getName().equals("submitSatisfaction")) {
+                hasSubmitSatisfaction = true;
+                break;
+            }
+        }
+        assertTrue(hasSubmitSatisfaction,
+                "[butler.quality.qa] ButlerSatisfactionService 应提供 submitSatisfaction(...) 方法作为满意度评分提交入口(SC-H-07)。");
+    }
+
+    @Test
+    @DisplayName("正常流-5:ButlerPerformanceService 绩效看板服务类应存在")
+    void butlerPerformanceService_classExists() {
+        assertNotNull(loadClass(BUTLER_PERFORMANCE_SERVICE),
+                "[butler.quality.qa] ButlerPerformanceService 类不存在:契约要求质检结果回流至真人管家绩效看板,"
+                        + "仅授权角色可见(SC-H-07)。实现未落地。");
+    }
+
+    @Test
+    @DisplayName("正常流-6:ButlerQualityInspection 质检记录实体应存在并承载逐项质检结果")
+    void butlerQualityInspection_entityExists() {
+        Class<?> entity = loadClass(QUALITY_INSPECTION_ENTITY);
+        if (entity == null) {
+            fail("[butler.quality.qa] ButlerQualityInspection 实体不存在:SC-H-07 要求质检报告逐项给出"
+                    + "通过/不通过与依据,应有 ButlerQualityInspection 实体承载。");
+        }
+        boolean hasInspectionItems = false;
+        for (Field f : entity.getDeclaredFields()) {
+            if (f.getName().equals("inspectionItems")) {
+                hasInspectionItems = true;
+                break;
+            }
+        }
+        assertTrue(hasInspectionItems,
+                "[butler.quality.qa] ButlerQualityInspection 实体应含 inspectionItems 字段,承载逐项质检结果"
+                        + "(通过/不通过与依据,SC-H-07)。");
+    }
+
+    @Test
+    @DisplayName("正常流-7:ButlerSatisfaction 满意度实体应存在并承载评分")
+    void butlerSatisfaction_entityExists() {
+        Class<?> entity = loadClass(SATISFACTION_ENTITY);
+        if (entity == null) {
+            fail("[butler.quality.qa] ButlerSatisfaction 实体不存在:SC-H-07 要求家长提交满意度评分,"
+                    + "应有 ButlerSatisfaction 实体承载评分。");
+        }
+        boolean hasRating = false;
+        for (Field f : entity.getDeclaredFields()) {
+            if (f.getName().equals("rating")) {
+                hasRating = true;
+                break;
+            }
+        }
+        assertTrue(hasRating,
+                "[butler.quality.qa] ButlerSatisfaction 实体应含 rating 字段,承载家长对管家服务的满意度评分(SC-H-07)。");
+    }
+
+    @Test
+    @DisplayName("正常流-8:schema.sql 应含质检/满意度/绩效三张表(SC-H-07 建表落地)")
+    void schemaSql_containsQualityTables() {
+        String schema = readSchemaSql();
+        for (String table : QUALITY_TABLES) {
+            assertTrue(schema.contains(table),
+                    "[butler.quality.qa] schema.sql 缺少 " + table + " 建表(SC-H-07 质检/满意度/绩效表落地)。");
+        }
+    }
+
+    // ------------------------------------------------------------------
+    // 边界流:隐私保护与差评触发复盘(SC-H-07 异常流)
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("边界流-1:ButlerQualityInspection 应含 desensitizedSummary 字段(质检不泄露对话原文)")
+    void butlerQualityInspection_hasDesensitizedSummary() {
+        Class<?> entity = loadClass(QUALITY_INSPECTION_ENTITY);
+        if (entity == null) {
+            fail("[butler.quality.qa] ButlerQualityInspection 实体不存在,无法验证脱敏摘要字段(SC-H-07)。");
+        }
+        boolean hasDesensitizedSummary = false;
+        for (Field f : entity.getDeclaredFields()) {
+            if (f.getName().equals("desensitizedSummary")) {
+                hasDesensitizedSummary = true;
+                break;
+            }
+        }
+        assertTrue(hasDesensitizedSummary,
+                "[butler.quality.qa] ButlerQualityInspection 实体应含 desensitizedSummary 字段:质检报告不展示"
+                        + "家长隐私对话原文,仅展示脱敏摘要与判定依据(SC-H-07 边界)。");
+    }
+
+    @Test
+    @DisplayName("边界流-2:ButlerQualityService 应提供 triggerRetrospect 差评触发复盘入口(关联 SC-H-04)")
+    void butlerQualityService_hasTriggerRetrospectMethod() {
+        Class<?> clazz = loadClass(BUTLER_QUALITY_SERVICE);
+        if (clazz == null) {
+            fail("[butler.quality.qa] ButlerQualityService 类不存在,无法验证 triggerRetrospect 差评复盘入口(SC-H-07)。");
+        }
+        boolean hasTriggerRetrospect = false;
+        for (Method m : clazz.getDeclaredMethods()) {
+            if (m.getName().equals("triggerRetrospect")) {
+                hasTriggerRetrospect = true;
+                break;
+            }
+        }
+        assertTrue(hasTriggerRetrospect,
+                "[butler.quality.qa] ButlerQualityService 应提供 triggerRetrospect(...) 方法:差评自动触发复盘并"
+                        + "关联 SC-H-04 升级应急流程(SC-H-07 异常流)。");
+    }
+
+    @Test
+    @DisplayName("边界流-3:ButlerSatisfaction 应含 badReviewTriggered 差评触发标记字段")
+    void butlerSatisfaction_hasBadReviewTriggeredField() {
+        Class<?> entity = loadClass(SATISFACTION_ENTITY);
+        if (entity == null) {
+            fail("[butler.quality.qa] ButlerSatisfaction 实体不存在,无法验证差评触发标记字段(SC-H-07)。");
+        }
+        boolean hasBadReviewTriggered = false;
+        for (Field f : entity.getDeclaredFields()) {
+            if (f.getName().equals("badReviewTriggered")) {
+                hasBadReviewTriggered = true;
+                break;
+            }
+        }
+        assertTrue(hasBadReviewTriggered,
+                "[butler.quality.qa] ButlerSatisfaction 实体应含 badReviewTriggered 字段,标记差评是否已触发复盘"
+                        + "(幂等,同一家长重复提交不重复计数,SC-H-07 异常流)。");
+    }
+
+    // ------------------------------------------------------------------
+    // 权限流(不适用):绩效看板权限在 Controller 层,本结构契约不覆盖
+    // ------------------------------------------------------------------
+
+    @Test
+    @DisplayName("权限流:butler.quality.qa 绩效看板权限在 Controller 层手动校验,本结构契约标注不适用")
+    void permissionFlow_notApplicable() {
+        // 说明性用例:SC-H-07 权限流(管家查本人绩效/查同事业绩403/家长查质检原文403/运营查全量质检)
+        // 在 Controller 层按角色手动校验,结构契约层不产生断言失败;仅标注「不适用」。
+        assertTrue(true, "权限流不适用:butler.quality.qa 绩效看板权限控制在 Controller 层(TC-H-07-P)。");
+    }
+
+    // ------------------------------------------------------------------
+    // 反射辅助
+    // ------------------------------------------------------------------
+
+    private Class<?> loadClass(String name) {
+        try {
+            return Class.forName(name, false, Thread.currentThread().getContextClassLoader());
+        } catch (ClassNotFoundException e) {
+            return null;
+        }
+    }
+
+    private String readSchemaSql() {
+        try (InputStream is = getClass().getClassLoader().getResourceAsStream("schema.sql")) {
+            if (is == null) {
+                return "";
+            }
+            try (Scanner scanner = new Scanner(is, StandardCharsets.UTF_8.name())) {
+                scanner.useDelimiter("\\A");
+                return scanner.hasNext() ? scanner.next() : "";
+            }
+        } catch (Exception e) {
+            return "";
+        }
+    }
+}