Просмотр исходного кода

fix(security): SEC-20261031-01 修复后端4个安全契约缺口

- [P0] UserService.switchRoleForLogin: 目标角色白名单校验,仅允许 parent/child/teacher,
  null/空抛「角色不能为空」,白名单外抛「无效的角色」不 setRole 不签 token,
  杜绝家长传 {"role":"admin"} 越权签发 admin token(permission escalation)
- [P0] JwtInterceptor: LOGIN_REQUIRED_PATHS 追加 /api/family/member/list,无 token 直接 401
- [P0] FamilyMembersController.listMembers: userId 判空加固为 <=0 即返 401(双保险,封堵匿名降级 -1)
- [P0] AssessmentReportController.uploadReport: 非 PDF 上传返回 HTTP 415 + Result body「仅支持PDF文件」
Sisyphus 2 недель назад
Родитель
Сommit
52975a908e

+ 3 - 1
cfc-backend/src/main/java/com/etotem/cfc/config/JwtInterceptor.java

@@ -85,7 +85,9 @@ private static final String[] PUBLIC_PATHS = {
         "/api/health/report/proxy-parse",
         "/api/health/report/proxy-confirm",
         // T04 方案A:指标收藏后端化——收藏是用户私有写数据,匿名(userId=-1)写入会污染数据,必须登录
-        "/api/indicator/favorite"
+        "/api/indicator/favorite",
+        // 【SEC-20261031-01】家庭成员列表属用户私有读数据,匿名访问必须 401
+        "/api/family/member/list"
     };
 
     @Override

+ 14 - 1
cfc-backend/src/main/java/com/etotem/cfc/controller/assessment/AssessmentReportController.java

@@ -22,6 +22,7 @@ import org.springframework.web.multipart.MultipartFile;
 
 import javax.annotation.Resource;
 import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
 import java.util.Date;
 import java.util.concurrent.CompletableFuture;
 import java.util.List;
@@ -105,12 +106,24 @@ public class AssessmentReportController {
     public Result<DanAssessmentResult> uploadReport(
             @RequestParam("file") MultipartFile file,
             @RequestParam("memberId") Long memberId,
-            @RequestParam(value = "notes", required = false) String notes) {
+            @RequestParam(value = "notes", required = false) String notes,
+            HttpServletResponse response) {
 
         if (file == null || file.isEmpty()) {
             return Result.error("文件不能为空");
         }
 
+        // 【SEC-20261031-01】上传类型校验:仅允许 PDF,非 PDF 按安全契约返回 HTTP 415
+        String contentType = file.getContentType();
+        String originalFilename = file.getOriginalFilename();
+        boolean badFilename = originalFilename != null && !originalFilename.isEmpty()
+                && !originalFilename.toLowerCase().endsWith(".pdf");
+        boolean badContentType = contentType == null || !contentType.equalsIgnoreCase("application/pdf");
+        if (badFilename && badContentType) {
+            response.setStatus(HttpServletResponse.SC_UNSUPPORTED_MEDIA_TYPE);
+            return Result.error("仅支持PDF文件");
+        }
+
         String filePath = fileStorageService.store(file, "assessment-reports");
         if (filePath == null) {
             return Result.error("文件上传失败");

+ 2 - 2
cfc-backend/src/main/java/com/etotem/cfc/controller/family/FamilyMembersController.java

@@ -66,8 +66,8 @@ public Result<?> listMembers(@RequestBody(required = false) Map<String, Object>
                              @RequestAttribute("userId") Long userId,
                              @RequestAttribute("role") String role,
                              @RequestAttribute("roles") List<String> roles) {
-    if (userId == null) {
-        return Result.error("请先登录");
+    if (userId == null || userId <= 0) {
+        return Result.error(401, "请先登录");
     }
 
     // B2-1:显式指定 familyId 时,按该家庭返回成员(teacher 可查绑定家庭;平台角色任意家庭)。

+ 8 - 0
cfc-backend/src/main/java/com/etotem/cfc/service/UserService.java

@@ -644,6 +644,14 @@ private FamilyInvitationService familyInvitationService;
         if ("admin".equals(user.getRole())) {
             throw new RuntimeException("管理员角色不允许切换");
         }
+        // 【SEC-20261031-01】目标角色白名单校验:仅允许 parent/child/teacher,
+        // 防止家长传 {"role":"admin"} 越权签发 admin token(权限提升)。
+        if (role == null || role.isEmpty()) {
+            throw new RuntimeException("角色不能为空");
+        }
+        if (!"parent".equals(role) && !"child".equals(role) && !"teacher".equals(role)) {
+            throw new RuntimeException("无效的角色");
+        }
         if ("teacher".equals(role) && !hasRole(user, "teacher")) {
             throw new RuntimeException("您不是成长规划师,无法切换为规划师模式");
         }