|
|
@@ -0,0 +1,325 @@
|
|
|
+package com.etotem.cfc.unit;
|
|
|
+
|
|
|
+import org.junit.jupiter.api.DisplayName;
|
|
|
+import org.junit.jupiter.api.Test;
|
|
|
+import org.springframework.web.bind.annotation.PostMapping;
|
|
|
+import org.springframework.web.bind.annotation.RequestAttribute;
|
|
|
+import org.springframework.web.bind.annotation.RequestMapping;
|
|
|
+
|
|
|
+import java.io.InputStream;
|
|
|
+import java.lang.annotation.Annotation;
|
|
|
+import java.lang.reflect.Field;
|
|
|
+import java.lang.reflect.Method;
|
|
|
+import java.lang.reflect.Parameter;
|
|
|
+import java.nio.charset.StandardCharsets;
|
|
|
+import java.util.Arrays;
|
|
|
+import java.util.Map;
|
|
|
+import java.util.Scanner;
|
|
|
+
|
|
|
+import static org.junit.jupiter.api.Assertions.assertNotNull;
|
|
|
+import static org.junit.jupiter.api.Assertions.assertTrue;
|
|
|
+import static org.junit.jupiter.api.Assertions.fail;
|
|
|
+
|
|
|
+/**
|
|
|
+ * 契约级单测:普通商品订单「我的评价/待评价」入口(能力键 {@code shop.review.my},任务 S-be-6,TDD-RED 阶段)。
|
|
|
+ *
|
|
|
+ * <p><b>契约溯源</b></p>
|
|
|
+ * <ul>
|
|
|
+ * <li>需求:{@code docs/superpowers/specs/2026-11-14-product-order-gap-prd.md} §3 P0-A
|
|
|
+ * —— 验收3「买家可在『我的评价/待评价』看到入口」(completed 且 90 天内且未评的普通商品订单;
|
|
|
+ * 已合入主线 85a64e02b)</li>
|
|
|
+ * <li>设计:{@code docs/superpowers/specs/2026-11-14-product-order-gap-arch-design.md}
|
|
|
+ * §3.1 R5({@code POST /api/product/review/my},登录买家,{@code {page,size}} →
|
|
|
+ * {@code Result<Map>}: {@code {reviews[], reviewableOrders[], reviewableCount}},已合入主线 85a64e02b)
|
|
|
+ * + §5.3 类图({@code ProductReviewService.my(Long userId, int page, int size): Map})</li>
|
|
|
+ * </ul>
|
|
|
+ *
|
|
|
+ * <p><b>R5 契约(本测试断言锚点)</b></p>
|
|
|
+ * <ul>
|
|
|
+ * <li>路由:{@code POST /api/product/review/my},鉴权=登录(买家)——Controller 方法必须携带
|
|
|
+ * {@code @RequestAttribute("userId")}(对齐既有 {@code ProductOrderController} 同点位写法)</li>
|
|
|
+ * <li>入参:{@code {page, size}};出参 {@code Result<Map>}:
|
|
|
+ * {@code reviews[]}(我的评价列表)+ {@code reviewableOrders[]}(待评价订单)
|
|
|
+ * + {@code reviewableCount}(待评价条数,= reviewableOrders 条数)</li>
|
|
|
+ * <li>待评价口径(PRD §3 P0-A 验收3 + §3.1 R5 要点):{@code status=completed} 且
|
|
|
+ * {@code confirmTime >= now-90d}(Q4 默认窗口)且未评({@code findByOrderId} 为 null)
|
|
|
+ * 且普通商品({@code productType != 'activity'})的买家本人订单</li>
|
|
|
+ * <li>数据:独立表 {@code product_reviews}(按 {@code reviewer_id} 查我的评价,
|
|
|
+ * {@code findReviewableOrderIds} 查待评价订单 ID 列表)</li>
|
|
|
+ * </ul>
|
|
|
+ *
|
|
|
+ * <p><b>实现现状</b>:本分支 src/main 中 {@code ProductReviewController} /
|
|
|
+ * {@code ProductReviewService} / {@code ProductReviewServiceImpl} <b>均未落地</b>(T02 未合入);
|
|
|
+ * 数据底座已落地(T01:{@code product_reviews} 建表 + {@code ProductReview} 实体 +
|
|
|
+ * {@code ProductReviewMapper.findReviewableOrderIds})。因此本测试以「反射结构契约」探测实现缺失:
|
|
|
+ * 宿主类缺失即断言失败(红),失败断言原文清晰可贴(对齐同批 {@code TeamProfitHookContractTest} /
|
|
|
+ * 同域 {@code ProductReviewCreateContractTest} 风格)。</p>
|
|
|
+ *
|
|
|
+ * <p><b>RED 预期</b>:Controller / Service 契约断言全部失败(红)——「我的评价/待评价」入口
|
|
|
+ * 未实现;GREEN 阶段实现方按上述契约清单落地后转绿。数据层锚点(实体/建表/待评价 Mapper)
|
|
|
+ * 已随 T01 落地,为正常通过项,不算 RED 目标。</p>
|
|
|
+ *
|
|
|
+ * <p><b>测试范围</b>:纯契约级,无 Spring / 无 DB / 无外部服务。</p>
|
|
|
+ */
|
|
|
+class ProductReviewMyContractTest {
|
|
|
+
|
|
|
+ /** R5 控制器(设计 §3.1,前缀 /api/product/review)。 */
|
|
|
+ private static final String CONTROLLER = "com.etotem.cfc.controller.product.ProductReviewController";
|
|
|
+ private static final String CONTROLLER_PREFIX = "/api/product/review";
|
|
|
+
|
|
|
+ /** R5 服务接口(设计 §5.3 类图:my(Long, int, int): Map)。 */
|
|
|
+ private static final String SERVICE = "com.etotem.cfc.service.ProductReviewService";
|
|
|
+
|
|
|
+ /** R5 服务实现(设计 §5.3 类图 + §6 T02:service/impl 包或 service 包内,两处任一落地即可)。 */
|
|
|
+ private static final String[] SERVICE_IMPL_CANDIDATES = {
|
|
|
+ "com.etotem.cfc.service.ProductReviewServiceImpl",
|
|
|
+ "com.etotem.cfc.service.impl.ProductReviewServiceImpl"
|
|
|
+ };
|
|
|
+
|
|
|
+ /** 待评价数据源锚点(设计 §5.3 类图注解:completed 且 90 天内且未评、买家本人、非 activity)。 */
|
|
|
+ private static final String MAPPER = "com.etotem.cfc.mapper.ProductReviewMapper";
|
|
|
+
|
|
|
+ /** 我的评价落库实体(设计 §2.1 建表 + §5.3 类图)。 */
|
|
|
+ private static final String ENTITY = "com.etotem.cfc.entity.ProductReview";
|
|
|
+
|
|
|
+ /** §2.1 独立表名(区别于活动评价 review_orders,两域不串)。 */
|
|
|
+ private static final String TABLE_NAME = "product_reviews";
|
|
|
+
|
|
|
+ /** 我的评价展示所需实体字段(我的评价列表渲染:商品/星级/文字/晒图/商家回复)。 */
|
|
|
+ private static final String[] MY_REVIEW_DISPLAY_FIELDS = {
|
|
|
+ "id", "orderId", "productId", "reviewerId", "rating", "reviewText", "images",
|
|
|
+ "reviewAt", "replyText", "repliedAt"
|
|
|
+ };
|
|
|
+
|
|
|
+ // ==================== 正常流:Controller 契约(§3.1 R5 路由) ====================
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-1:ProductReviewController 类应存在")
|
|
|
+ void controller_classExists() {
|
|
|
+ assertNotNull(loadClass(CONTROLLER),
|
|
|
+ "[shop.review.my] ProductReviewController 类不存在:契约要求新增独立控制器,"
|
|
|
+ + "路由前缀 /api/product/review(设计 §3.1 R5,PRD §3 P0-A 验收3 我的评价入口)。"
|
|
|
+ + "实现未落地。");
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-2:控制器应映射到 /api/product/review 前缀")
|
|
|
+ void controller_classMappingPrefix() {
|
|
|
+ Class<?> clazz = loadClass(CONTROLLER);
|
|
|
+ if (clazz == null) {
|
|
|
+ fail("[shop.review.my] ProductReviewController 类不存在,无法验证前缀映射(§3.1 R5)。");
|
|
|
+ }
|
|
|
+ boolean mapped = false;
|
|
|
+ for (Annotation a : clazz.getAnnotations()) {
|
|
|
+ if (a instanceof RequestMapping) {
|
|
|
+ RequestMapping rm = (RequestMapping) a;
|
|
|
+ mapped = Arrays.asList(rm.value()).contains(CONTROLLER_PREFIX)
|
|
|
+ || Arrays.asList(rm.path()).contains(CONTROLLER_PREFIX);
|
|
|
+ }
|
|
|
+ }
|
|
|
+ assertTrue(mapped,
|
|
|
+ "[shop.review.my] ProductReviewController 类级映射应含 " + CONTROLLER_PREFIX
|
|
|
+ + "(§3.1 R5 前缀 /api/product/review)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-3:my 方法应标注 POST /my(完整路由 /api/product/review/my)")
|
|
|
+ void controller_myPostMapping() {
|
|
|
+ Class<?> clazz = loadClass(CONTROLLER);
|
|
|
+ if (clazz == null) {
|
|
|
+ fail("[shop.review.my] ProductReviewController 类不存在,无法验证 my 路由(§3.1 R5)。");
|
|
|
+ }
|
|
|
+ Method my = findMethod(clazz, "my");
|
|
|
+ assertNotNull(my,
|
|
|
+ "[shop.review.my] ProductReviewController 应提供 my 方法"
|
|
|
+ + "(POST /api/product/review/my,§3.1 R5 我的评价/待评价入口)。");
|
|
|
+ PostMapping pm = my.getAnnotation(PostMapping.class);
|
|
|
+ assertNotNull(pm,
|
|
|
+ "[shop.review.my] my 方法应标注 @PostMapping(统一 @PostMapping 规约,§3.1 R5)。");
|
|
|
+ boolean routeOk = Arrays.asList(pm.value()).contains("/my")
|
|
|
+ || Arrays.asList(pm.path()).contains("/my");
|
|
|
+ assertTrue(routeOk,
|
|
|
+ "[shop.review.my] my 应映射 POST /my(完整路由 /api/product/review/my,§3.1 R5)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-4:my 应携带 @RequestAttribute(\"userId\")(登录买家)")
|
|
|
+ void controller_myCarriesBuyerIdentity() {
|
|
|
+ Class<?> clazz = loadClass(CONTROLLER);
|
|
|
+ if (clazz == null) {
|
|
|
+ fail("[shop.review.my] ProductReviewController 类不存在,无法验证鉴权参数(§3.1 R5)。");
|
|
|
+ }
|
|
|
+ Method my = findMethod(clazz, "my");
|
|
|
+ assertNotNull(my, "[shop.review.my] my 方法不存在(§3.1 R5)。");
|
|
|
+ boolean hasUserId = false;
|
|
|
+ for (Parameter p : my.getParameters()) {
|
|
|
+ RequestAttribute ra = p.getAnnotation(RequestAttribute.class);
|
|
|
+ if (ra != null && "userId".equals(ra.value())) {
|
|
|
+ hasUserId = true;
|
|
|
+ break;
|
|
|
+ }
|
|
|
+ }
|
|
|
+ assertTrue(hasUserId,
|
|
|
+ "[shop.review.my] my 应携带 @RequestAttribute(\"userId\") 读取登录买家身份"
|
|
|
+ + "(鉴权=登录买家,对齐 ProductOrderController 同点位写法,§3.1 R5 鉴权列)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== 正常流:Service 契约(§3.1 R5 + §5.3 类图) ====================
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-5:ProductReviewService 接口应存在并提供 my 契约方法(返回 Map)")
|
|
|
+ void service_interfaceHasMyMethod() {
|
|
|
+ Class<?> clazz = loadClass(SERVICE);
|
|
|
+ assertNotNull(clazz,
|
|
|
+ "[shop.review.my] ProductReviewService 接口不存在:独立 ProductReview* 服务契约"
|
|
|
+ + "(§5.3 类图)。实现未落地。");
|
|
|
+ Method my = findMethod(clazz, "my");
|
|
|
+ assertNotNull(my,
|
|
|
+ "[shop.review.my] ProductReviewService 应提供 my(...) 方法"
|
|
|
+ + "(R5 我的评价/待评价入口,合同签名 my(Long userId, int page, int size),§5.3 类图)。");
|
|
|
+ assertTrue(my.getParameterCount() == 3,
|
|
|
+ "[shop.review.my] my 应接收 3 参(userId/page/size)(§5.3 类图 my(Long, int, int))。");
|
|
|
+ assertTrue(Map.class.isAssignableFrom(my.getReturnType()),
|
|
|
+ "[shop.review.my] my 应返回 Map 承载 {reviews[], reviewableOrders[], reviewableCount}"
|
|
|
+ + "(§3.1 R5 出参 + §5.3 类图 my(...): Map)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("正常流-6:ProductReviewServiceImpl 应落地并实现 ProductReviewService")
|
|
|
+ void serviceImpl_implementsInterface() {
|
|
|
+ Class<?> impl = loadAnyImpl();
|
|
|
+ assertNotNull(impl,
|
|
|
+ "[shop.review.my] ProductReviewServiceImpl 不存在:契约要求独立 ProductReview* 服务实现"
|
|
|
+ + "(PRD §3 P0-A:活动 ReviewOrderServiceImpl 零改动,不走复用;§6 T02)。实现未落地。");
|
|
|
+ boolean anyImpl = false;
|
|
|
+ for (Class<?> itf : impl.getInterfaces()) {
|
|
|
+ if (SERVICE.equals(itf.getName())) {
|
|
|
+ anyImpl = true;
|
|
|
+ break;
|
|
|
+ }
|
|
|
+ }
|
|
|
+ assertTrue(anyImpl,
|
|
|
+ "[shop.review.my] ProductReviewServiceImpl 应实现 ProductReviewService 接口(§5.3 类图)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== 边界流:待评价口径数据契约(PRD §3 P0-A 验收3 + §3.1 R5) ====================
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("边界流-1:ProductReviewMapper 应提供 findReviewableOrderIds(待评价订单 ID 列表)")
|
|
|
+ void mapper_findReviewableOrderIds() {
|
|
|
+ Class<?> clazz = loadClass(MAPPER);
|
|
|
+ assertNotNull(clazz,
|
|
|
+ "[shop.review.my] ProductReviewMapper 不存在:独立商品评价 Mapper 契约"
|
|
|
+ + "(§5.3 类图,待评价数据源)。");
|
|
|
+ Method method = findMethod(clazz, "findReviewableOrderIds");
|
|
|
+ assertNotNull(method,
|
|
|
+ "[shop.review.my] ProductReviewMapper 应提供 findReviewableOrderIds(buyerId, since) 方法"
|
|
|
+ + "——completed 且 90 天内(Q4 窗口)且未评的买家本人普通商品订单(PRD §3 P0-A 验收3)。");
|
|
|
+ assertTrue(method.getParameterCount() >= 2,
|
|
|
+ "[shop.review.my] findReviewableOrderIds 应接收 buyerId + since(90天窗口基准) 2 参");
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("边界流-2:ProductReview 实体应承载我的评价展示字段")
|
|
|
+ void entity_carriesMyReviewDisplayFields() {
|
|
|
+ Class<?> clazz = loadClass(ENTITY);
|
|
|
+ if (clazz == null) {
|
|
|
+ fail("[shop.review.my] ProductReview 实体不存在:新表 product_reviews 落库载体"
|
|
|
+ + "(§2.1 建表)。");
|
|
|
+ }
|
|
|
+ for (String field : MY_REVIEW_DISPLAY_FIELDS) {
|
|
|
+ boolean present = false;
|
|
|
+ for (Field f : clazz.getDeclaredFields()) {
|
|
|
+ if (field.equals(f.getName())) {
|
|
|
+ present = true;
|
|
|
+ break;
|
|
|
+ }
|
|
|
+ }
|
|
|
+ assertTrue(present,
|
|
|
+ "[shop.review.my] ProductReview 实体应含 " + field
|
|
|
+ + " 字段(我的评价列表渲染所需,对应 "
|
|
|
+ + camelToSnake(field) + ",§2.1 product_reviews 建表)。");
|
|
|
+ }
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("边界流-3:product_reviews 独立表应落地 schema.sql(含 reviewer_id 索引)")
|
|
|
+ void schemaSql_hasProductReviewsTableWithReviewerIndex() {
|
|
|
+ String schema = readSchemaSql();
|
|
|
+ assertTrue(schema.contains(TABLE_NAME),
|
|
|
+ "[shop.review.my] schema.sql 缺少 product_reviews 建表"
|
|
|
+ + "(§2.1 迁移464,Q1 拍板=独立表,不复用 review_orders 活动评价表)。");
|
|
|
+ int idx = schema.indexOf(TABLE_NAME);
|
|
|
+ String tableBlock = idx >= 0 ? schema.substring(idx) : "";
|
|
|
+ assertTrue(tableBlock.contains("idx_reviewer_id"),
|
|
|
+ "[shop.review.my] product_reviews 应含 idx_reviewer_id 索引"
|
|
|
+ + "(我的评价按 reviewer_id 查询,§2.1 建表)。");
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== 权限流:R5 鉴权=登录买家(R3 公开读与此无关) ====================
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("权限流:R5 鉴权=登录(买家本人),非公开只读接口(R3 list 才是公开)")
|
|
|
+ void permissionFlow_loginBuyerOnly_notPublicPath() {
|
|
|
+ // 设计 §3.1 R5 鉴权列=「登录(买家)」:我的评价/待评价为买家私有数据,须携带
|
|
|
+ // @RequestAttribute("userId")(已由 正常流-4 断言);与 R3 list(PUBLIC_PATHS 公开只读)
|
|
|
+ // 严格区分,本能力不登记公开路径。此处为说明性用例,不产生断言失败。
|
|
|
+ assertTrue(true, "权限流说明:shop.review.my 为登录买家私有接口,不适用 R3 公开读路径。");
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== 反射辅助(对齐 TeamProfitHookContractTest / ProductReviewCreateContractTest 风格) ====================
|
|
|
+
|
|
|
+ private Class<?> loadClass(String name) {
|
|
|
+ try {
|
|
|
+ return Class.forName(name, false, Thread.currentThread().getContextClassLoader());
|
|
|
+ } catch (ClassNotFoundException e) {
|
|
|
+ return null;
|
|
|
+ }
|
|
|
+ }
|
|
|
+
|
|
|
+ /** 服务实现两处候选位置(§6 T02:service/impl 包或 service 包内)。 */
|
|
|
+ private Class<?> loadAnyImpl() {
|
|
|
+ for (String candidate : SERVICE_IMPL_CANDIDATES) {
|
|
|
+ Class<?> clazz = loadClass(candidate);
|
|
|
+ if (clazz != null) {
|
|
|
+ return clazz;
|
|
|
+ }
|
|
|
+ }
|
|
|
+ return null;
|
|
|
+ }
|
|
|
+
|
|
|
+ private Method findMethod(Class<?> clazz, String name) {
|
|
|
+ for (Method m : clazz.getDeclaredMethods()) {
|
|
|
+ if (m.getName().equals(name)) {
|
|
|
+ return m;
|
|
|
+ }
|
|
|
+ }
|
|
|
+ return null;
|
|
|
+ }
|
|
|
+
|
|
|
+ private String camelToSnake(String camel) {
|
|
|
+ StringBuilder sb = new StringBuilder();
|
|
|
+ for (char c : camel.toCharArray()) {
|
|
|
+ if (Character.isUpperCase(c)) {
|
|
|
+ sb.append('_').append(Character.toLowerCase(c));
|
|
|
+ } else {
|
|
|
+ sb.append(c);
|
|
|
+ }
|
|
|
+ }
|
|
|
+ return sb.toString();
|
|
|
+ }
|
|
|
+
|
|
|
+ private String readSchemaSql() {
|
|
|
+ try (InputStream is = getClass().getClassLoader().getResourceAsStream("schema.sql")) {
|
|
|
+ if (is == null) {
|
|
|
+ return "";
|
|
|
+ }
|
|
|
+ try (Scanner scanner = new Scanner(is, StandardCharsets.UTF_8.name())) {
|
|
|
+ scanner.useDelimiter("\\A");
|
|
|
+ return scanner.hasNext() ? scanner.next() : "";
|
|
|
+ }
|
|
|
+ } catch (Exception e) {
|
|
|
+ return "";
|
|
|
+ }
|
|
|
+ }
|
|
|
+}
|