|
|
@@ -0,0 +1,618 @@
|
|
|
+package com.etotem.cfc.unit;
|
|
|
+
|
|
|
+import com.baomidou.mybatisplus.core.MybatisConfiguration;
|
|
|
+import com.baomidou.mybatisplus.core.conditions.Wrapper;
|
|
|
+import com.baomidou.mybatisplus.core.metadata.TableInfoHelper;
|
|
|
+import com.etotem.cfc.entity.ArticleQuizRecord;
|
|
|
+import com.etotem.cfc.entity.ArticleReadingRecord;
|
|
|
+import com.etotem.cfc.entity.Task;
|
|
|
+import com.etotem.cfc.entity.TaskArticleProgress;
|
|
|
+import com.etotem.cfc.mapper.ArticleQuizRecordMapper;
|
|
|
+import com.etotem.cfc.mapper.ArticleReadingRecordMapper;
|
|
|
+import com.etotem.cfc.mapper.FamilyMemberMapper;
|
|
|
+import com.etotem.cfc.mapper.TaskArticleProgressMapper;
|
|
|
+import com.etotem.cfc.mapper.TaskMapper;
|
|
|
+import com.etotem.cfc.service.ArticleReadingTaskService;
|
|
|
+import com.etotem.cfc.service.SysConfigService;
|
|
|
+import com.etotem.cfc.service.TaskService;
|
|
|
+import org.apache.ibatis.builder.MapperBuilderAssistant;
|
|
|
+import org.junit.jupiter.api.BeforeAll;
|
|
|
+import org.junit.jupiter.api.BeforeEach;
|
|
|
+import org.junit.jupiter.api.DisplayName;
|
|
|
+import org.junit.jupiter.api.Test;
|
|
|
+import org.mockito.ArgumentCaptor;
|
|
|
+import org.springframework.dao.DuplicateKeyException;
|
|
|
+
|
|
|
+import java.lang.reflect.Field;
|
|
|
+import java.util.Arrays;
|
|
|
+import java.util.Collections;
|
|
|
+import java.util.List;
|
|
|
+import java.util.Map;
|
|
|
+
|
|
|
+import static org.junit.jupiter.api.Assertions.assertEquals;
|
|
|
+import static org.junit.jupiter.api.Assertions.assertFalse;
|
|
|
+import static org.junit.jupiter.api.Assertions.assertNotNull;
|
|
|
+import static org.junit.jupiter.api.Assertions.assertThrows;
|
|
|
+import static org.junit.jupiter.api.Assertions.assertTrue;
|
|
|
+import static org.mockito.ArgumentMatchers.any;
|
|
|
+import static org.mockito.ArgumentMatchers.anyLong;
|
|
|
+import static org.mockito.ArgumentMatchers.eq;
|
|
|
+import static org.mockito.Mockito.mock;
|
|
|
+import static org.mockito.Mockito.never;
|
|
|
+import static org.mockito.Mockito.verify;
|
|
|
+import static org.mockito.Mockito.when;
|
|
|
+
|
|
|
+/**
|
|
|
+ * 阅读打卡任务三模式完成判定契约测试(ARCH-CFC-READING-CHECKIN-001 §10 十个场景,纯 Mockito 无 Spring 上下文)。
|
|
|
+ *
|
|
|
+ * <p>测试对象(Group A):{@link ArticleReadingTaskService} —— 三模式门控 + 自动完成触发 +
|
|
|
+ * 进度查询;Group B:{@link TaskService#completeTask} 的 article 兜底门控(§5.2 防前端绕过)。
|
|
|
+ * 风格参考 {@code ShopCouponClaimContractTest}:{@code new X()} + 反射注入 mock,不启动 Spring。</p>
|
|
|
+ *
|
|
|
+ * <p>覆盖流(映射设计 §10):</p>
|
|
|
+ * <ul>
|
|
|
+ * <li>场景 1:A 读够时长 + 答题通过 → completeTask 触发一次;进度 done=1/quizPassed=true;</li>
|
|
|
+ * <li>场景 2:A 读够时长 + 答题不通过 → completeTask 不触发;quizPassed=false;</li>
|
|
|
+ * <li>场景 3:A 读够时长但未答题 → completeTask 兜底门控拒绝「请先通过测试题后再完成」;</li>
|
|
|
+ * <li>场景 4:B 选未完成文章读够时长 → report 达标 → completeTask 一次;done=1;</li>
|
|
|
+ * <li>场景 5:B 选已完成文章(无新 task 记录)→ durationQualified=false,不完成;</li>
|
|
|
+ * <li>场景 6:C 读 1 篇过题 → ledger +1 → 集满 N → completeTask 一次;进度返回 done/target;</li>
|
|
|
+ * <li>场景 7:C 读 1 篇但答题不通过 → 不计入 ledger,不完成;</li>
|
|
|
+ * <li>场景 8:A 文章下架/无答题记录 → 门控拒绝(不泄漏完成);</li>
|
|
|
+ * <li>场景 9:重复记账(唯一键 DuplicateKeyException)→ 视为已计,不重复 +1;completeTask 幂等不重复发奖;</li>
|
|
|
+ * <li>场景 10:任务过期(时间窗)→ tryCompleteArticleTask 自动完成被拒仅 warn 不抛,进度保留;每日型新 task_id 进度隔离。</li>
|
|
|
+ * </ul>
|
|
|
+ */
|
|
|
+class ReadingCheckinContractTest {
|
|
|
+
|
|
|
+ private static final Long TASK_ID = 1001L;
|
|
|
+ private static final Long MEMBER_ID = 2001L;
|
|
|
+ private static final Long ARTICLE_ID = 3001L;
|
|
|
+ private static final Long OTHER_ARTICLE_ID = 3002L;
|
|
|
+ private static final int MIN_SECONDS = 300;
|
|
|
+ private static final int TARGET_COUNT = 3;
|
|
|
+ private static final double PASS_RATE = 0.6;
|
|
|
+
|
|
|
+ /** 纯 Mockito 下 LambdaQueryWrapper / LambdaUpdateWrapper 需 TableInfo 缓存方能解析列名 */
|
|
|
+ @BeforeAll
|
|
|
+ static void initMpTableInfo() {
|
|
|
+ MapperBuilderAssistant assistant = new MapperBuilderAssistant(new MybatisConfiguration(), "");
|
|
|
+ TableInfoHelper.initTableInfo(assistant, Task.class);
|
|
|
+ TableInfoHelper.initTableInfo(assistant, ArticleReadingRecord.class);
|
|
|
+ TableInfoHelper.initTableInfo(assistant, ArticleQuizRecord.class);
|
|
|
+ TableInfoHelper.initTableInfo(assistant, TaskArticleProgress.class);
|
|
|
+ }
|
|
|
+
|
|
|
+ private ArticleReadingTaskService service;
|
|
|
+ private TaskService taskService;
|
|
|
+ private TaskMapper taskMapper;
|
|
|
+ private ArticleReadingRecordMapper articleReadingRecordMapper;
|
|
|
+ private ArticleQuizRecordMapper articleQuizRecordMapper;
|
|
|
+ private TaskArticleProgressMapper taskArticleProgressMapper;
|
|
|
+ private SysConfigService sysConfigService;
|
|
|
+ private ArticleReadingTaskService gateMock;
|
|
|
+
|
|
|
+ // ==================== Group A:ArticleReadingTaskService ====================
|
|
|
+
|
|
|
+ @BeforeEach
|
|
|
+ void setUp() throws Exception {
|
|
|
+ service = new ArticleReadingTaskService();
|
|
|
+ taskMapper = mock(TaskMapper.class);
|
|
|
+ articleReadingRecordMapper = mock(ArticleReadingRecordMapper.class);
|
|
|
+ articleQuizRecordMapper = mock(ArticleQuizRecordMapper.class);
|
|
|
+ taskArticleProgressMapper = mock(TaskArticleProgressMapper.class);
|
|
|
+ sysConfigService = mock(SysConfigService.class);
|
|
|
+ taskService = mock(TaskService.class);
|
|
|
+
|
|
|
+ inject(service, "taskService", taskService);
|
|
|
+ inject(service, "taskMapper", taskMapper);
|
|
|
+ inject(service, "articleReadingRecordMapper", articleReadingRecordMapper);
|
|
|
+ inject(service, "articleQuizRecordMapper", articleQuizRecordMapper);
|
|
|
+ inject(service, "taskArticleProgressMapper", taskArticleProgressMapper);
|
|
|
+ inject(service, "sysConfigService", sysConfigService);
|
|
|
+ }
|
|
|
+
|
|
|
+ private static void inject(Object target, String field, Object value) throws Exception {
|
|
|
+ Field f = target.getClass().getDeclaredField(field);
|
|
|
+ f.setAccessible(true);
|
|
|
+ f.set(target, value);
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- 场景 1/2/3/8:模式 A(指定文章 + 答题) --------------------
|
|
|
+
|
|
|
+ private Task articleTask(String actionConfig) {
|
|
|
+ Task task = new Task();
|
|
|
+ task.setId(TASK_ID);
|
|
|
+ task.setActionType("article");
|
|
|
+ task.setActionConfig(actionConfig);
|
|
|
+ task.setFamilyMemberId(MEMBER_ID);
|
|
|
+ task.setMinDurationSeconds(MIN_SECONDS);
|
|
|
+ return task;
|
|
|
+ }
|
|
|
+
|
|
|
+ /** 已通过该文章测试题:score=3/total=5 ≥ 0.6 */
|
|
|
+ private void stubQuizPassed() {
|
|
|
+ ArticleQuizRecord record = new ArticleQuizRecord();
|
|
|
+ record.setArticleId(ARTICLE_ID);
|
|
|
+ record.setMemberId(MEMBER_ID);
|
|
|
+ record.setScore(3);
|
|
|
+ record.setTotalQuestions(5);
|
|
|
+ when(articleQuizRecordMapper.selectList(any(Wrapper.class)))
|
|
|
+ .thenReturn(Collections.singletonList(record));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景1:A 读够时长+答题通过 → tryCompleteArticleTask 触发 completeTask 一次")
|
|
|
+ void tryComplete_articleQualified_completes() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3001,\"minSeconds\":300,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ stubQuizPassed();
|
|
|
+
|
|
|
+ service.tryCompleteArticleTask(TASK_ID, MEMBER_ID, ARTICLE_ID);
|
|
|
+
|
|
|
+ verify(taskService).completeTask(eq(TASK_ID), eq(MEMBER_ID), eq(null), eq(null), eq(null));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景1补充:A 查询进度 done=1 / quizPassed=true / readingCompleted=true")
|
|
|
+ void progress_articleDone() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3001,\"minSeconds\":300,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ stubQuizPassed();
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+
|
|
|
+ Map<String, Object> p = service.getTaskProgress(TASK_ID);
|
|
|
+
|
|
|
+ assertEquals("ARTICLE", p.get("mode"));
|
|
|
+ assertEquals(1, p.get("done"));
|
|
|
+ assertEquals(1, p.get("target"));
|
|
|
+ assertEquals(Boolean.TRUE, p.get("quizPassed"));
|
|
|
+ assertEquals(Boolean.TRUE, p.get("readingCompleted"));
|
|
|
+ assertEquals(300, p.get("minSeconds"));
|
|
|
+ assertEquals(ARTICLE_ID, p.get("articleId"));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景2:A 读够时长+答题不通过 → completeTask 不触发;quizPassed=false")
|
|
|
+ void tryComplete_articleQuizFailed_doesNotComplete() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3001,\"minSeconds\":300,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ // 无过题记录(题目记录缺失/分数不足)
|
|
|
+ when(articleQuizRecordMapper.selectList(any(Wrapper.class)))
|
|
|
+ .thenReturn(Collections.singletonList(quizRecord(2, 5))); // 2/5 < 0.6
|
|
|
+
|
|
|
+ service.tryCompleteArticleTask(TASK_ID, MEMBER_ID, ARTICLE_ID);
|
|
|
+
|
|
|
+ verify(taskService, never()).completeTask(anyLong(), anyLong(), any(), any(), any());
|
|
|
+ assertFalse(service.isQuizPassed(TASK_ID, 2, 5));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景3:A 读够时长但未答题 → completeTask 兜底门控拒绝")
|
|
|
+ void gate_articleNoQuiz_throws() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3001,\"minSeconds\":300,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ when(articleQuizRecordMapper.selectList(any(Wrapper.class))).thenReturn(Collections.emptyList());
|
|
|
+
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(task));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_QUIZ_NOT_PASSED, ex.getMessage());
|
|
|
+ // 自动完成路径也不触发
|
|
|
+ service.tryCompleteArticleTask(TASK_ID, MEMBER_ID, ARTICLE_ID);
|
|
|
+ verify(taskService, never()).completeTask(anyLong(), anyLong(), any(), any(), any());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景8:A 文章已下架/无任何答题记录 → 门控拒绝(不泄漏完成)")
|
|
|
+ void gate_articleUnavailable_throws() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3999,\"minSeconds\":300,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(articleQuizRecordMapper.selectList(any(Wrapper.class))).thenReturn(Collections.emptyList());
|
|
|
+
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(task));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_QUIZ_NOT_PASSED, ex.getMessage());
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- 场景 4/5:模式 B(按时长) --------------------
|
|
|
+
|
|
|
+ private Task durationTask(String actionConfig) {
|
|
|
+ Task task = new Task();
|
|
|
+ task.setId(TASK_ID);
|
|
|
+ task.setActionType("article");
|
|
|
+ task.setActionConfig(actionConfig);
|
|
|
+ task.setFamilyMemberId(MEMBER_ID);
|
|
|
+ task.setMinDurationSeconds(MIN_SECONDS);
|
|
|
+ return task;
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景4:B 选未完成文章读够时长 → onReadingCompleted 触发 completeTask 一次;进度 done=1")
|
|
|
+ void onReadingCompleted_bQualified_completes() {
|
|
|
+ Task task = durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300,\"requireQuiz\":false}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ // reading_completed=1 且 duration ≥ 300 的记录存在(task_id 关联)
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+
|
|
|
+ service.onReadingCompleted(TASK_ID, MEMBER_ID, 500L);
|
|
|
+
|
|
|
+ verify(taskService).completeTask(eq(TASK_ID), eq(MEMBER_ID), eq(null), eq(null), eq(null));
|
|
|
+
|
|
|
+ Map<String, Object> p = service.getTaskProgress(TASK_ID);
|
|
|
+ assertEquals("DURATION", p.get("mode"));
|
|
|
+ assertEquals(1, p.get("done"));
|
|
|
+ assertEquals(Boolean.TRUE, p.get("readingCompleted"));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景5:B 选已完成文章(无新 task 记录)→ 不达标不计数,任务保持 in_progress")
|
|
|
+ void onReadingCompleted_bNoTaskRecord_doesNotComplete() {
|
|
|
+ Task task = durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300,\"requireQuiz\":false}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ // 没有任何 task_id 关联的达标记录(按 task_id 隔离,已完成文章对本次任务无新记录)
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(0L);
|
|
|
+
|
|
|
+ service.onReadingCompleted(TASK_ID, MEMBER_ID, 500L);
|
|
|
+
|
|
|
+ verify(taskService, never()).completeTask(anyLong(), anyLong(), any(), any(), any());
|
|
|
+ Map<String, Object> p = service.getTaskProgress(TASK_ID);
|
|
|
+ assertEquals(0, p.get("done"));
|
|
|
+ assertEquals(Boolean.FALSE, p.get("readingCompleted"));
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- 场景 6/7/9:模式 C(按数量 ledger) --------------------
|
|
|
+
|
|
|
+ private Task countTask(String actionConfig) {
|
|
|
+ Task task = new Task();
|
|
|
+ task.setId(TASK_ID);
|
|
|
+ task.setActionType("article");
|
|
|
+ task.setActionConfig(actionConfig);
|
|
|
+ task.setFamilyMemberId(MEMBER_ID);
|
|
|
+ task.setTargetValue(TARGET_COUNT);
|
|
|
+ return task;
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景6:C 过题记账+1 → 集满 N → completeTask 一次;进度返回 done/target")
|
|
|
+ void onQuizSubmitted_countQualified_recordsAndCompletes() {
|
|
|
+ Task task = countTask("{\"mode\":\"COUNT\",\"targetCount\":3,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ // 本次过题记账后 ledger 达 target=3(selectCount 模拟 INSERT 后的当前值)
|
|
|
+ when(taskArticleProgressMapper.selectCount(any(Wrapper.class))).thenReturn(3L);
|
|
|
+
|
|
|
+ service.onQuizSubmitted(TASK_ID, MEMBER_ID, ARTICLE_ID, 4, 5);
|
|
|
+
|
|
|
+ // 记账 trigger(INSERT 成功)
|
|
|
+ ArgumentCaptor<TaskArticleProgress> captor = ArgumentCaptor.forClass(TaskArticleProgress.class);
|
|
|
+ verify(taskArticleProgressMapper).insert(captor.capture());
|
|
|
+ assertEquals(TASK_ID, captor.getValue().getTaskId());
|
|
|
+ assertEquals(ARTICLE_ID, captor.getValue().getArticleId());
|
|
|
+ assertEquals(MEMBER_ID, captor.getValue().getMemberId());
|
|
|
+ // 达 target → 自动完成一次
|
|
|
+ verify(taskService).completeTask(eq(TASK_ID), eq(MEMBER_ID), eq(null), eq(null), eq(null));
|
|
|
+
|
|
|
+ Map<String, Object> p = service.getTaskProgress(TASK_ID);
|
|
|
+ assertEquals("COUNT", p.get("mode"));
|
|
|
+ assertEquals(3, p.get("done"));
|
|
|
+ assertEquals(3, p.get("target"));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景6补充:C 未达 target 不完成(ledger 1/3),进度返回 done=1/target=3")
|
|
|
+ void onQuizSubmitted_countBelowTarget_noComplete() {
|
|
|
+ Task task = countTask("{\"mode\":\"COUNT\",\"targetCount\":3,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ when(taskArticleProgressMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+
|
|
|
+ service.onQuizSubmitted(TASK_ID, MEMBER_ID, ARTICLE_ID, 4, 5);
|
|
|
+
|
|
|
+ verify(taskArticleProgressMapper).insert(any(TaskArticleProgress.class));
|
|
|
+ verify(taskService, never()).completeTask(anyLong(), anyLong(), any(), any(), any());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景7:C 过题未通过 → 不计入 ledger,不完成")
|
|
|
+ void onQuizSubmitted_countQuizFailed_doesNothing() {
|
|
|
+ Task task = countTask("{\"mode\":\"COUNT\",\"targetCount\":3,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+
|
|
|
+ service.onQuizSubmitted(TASK_ID, MEMBER_ID, ARTICLE_ID, 2, 5); // 2/5 < 0.6
|
|
|
+
|
|
|
+ verify(taskArticleProgressMapper, never()).insert(any(TaskArticleProgress.class));
|
|
|
+ verify(taskService, never()).completeTask(anyLong(), anyLong(), any(), any(), any());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景9:C 重复记账(唯一键冲突)→ 视为已计,不重复 +1,不重复完成")
|
|
|
+ void recordArticleProgress_duplicate_returnsFalse() {
|
|
|
+ when(taskArticleProgressMapper.insert(any(TaskArticleProgress.class)))
|
|
|
+ .thenThrow(new DuplicateKeyException("uk_task_article dup"));
|
|
|
+
|
|
|
+ boolean first = service.recordArticleProgress(TASK_ID, MEMBER_ID, ARTICLE_ID);
|
|
|
+
|
|
|
+ assertFalse(first);
|
|
|
+ verify(taskArticleProgressMapper).insert(any(TaskArticleProgress.class));
|
|
|
+ }
|
|
|
+
|
|
|
+ @SuppressWarnings("unchecked")
|
|
|
+ @Test
|
|
|
+ @DisplayName("countArticleProgress:SQL 段含 task_id 过滤(每日型按 task_id 天然隔离)")
|
|
|
+ void countArticleProgress_scopedByTaskId() {
|
|
|
+ when(taskArticleProgressMapper.selectCount(any(Wrapper.class))).thenReturn(2L);
|
|
|
+
|
|
|
+ int count = service.countArticleProgress(TASK_ID);
|
|
|
+
|
|
|
+ assertEquals(2, count);
|
|
|
+ ArgumentCaptor<Wrapper<TaskArticleProgress>> captor = ArgumentCaptor.forClass(Wrapper.class);
|
|
|
+ verify(taskArticleProgressMapper).selectCount(captor.capture());
|
|
|
+ assertTrue(captor.getValue().getSqlSegment().contains("task_id"),
|
|
|
+ "ledger 计数必须按 task_id 过滤(每日型新 task_id 进度隔离)");
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- 场景 10:过期 / 每日型隔离 --------------------
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景10:任务过期(时间窗)→ tryComplete 自动完成被拒仅 warn 不抛;进度/进度台账保留")
|
|
|
+ void tryComplete_timeWindowRejected_swallowsException() {
|
|
|
+ Task task = durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300,\"requireQuiz\":false}");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+ when(taskService.completeTask(anyLong(), anyLong(), any(), any(), any()))
|
|
|
+ .thenThrow(new IllegalArgumentException("已过截止时间 23:00,无法提交"));
|
|
|
+
|
|
|
+ // 不向上抛(答题/阅读上报主流程不被打断)
|
|
|
+ service.tryCompleteArticleTask(TASK_ID, MEMBER_ID, null);
|
|
|
+
|
|
|
+ verify(taskService).completeTask(eq(TASK_ID), eq(MEMBER_ID), eq(null), eq(null), eq(null));
|
|
|
+ // 进度保留:ledger/reading record 仍可查
|
|
|
+ Map<String, Object> p = service.getTaskProgress(TASK_ID);
|
|
|
+ assertEquals(1, p.get("done"));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("场景10补充:每日型新 task_id → 进度按任务实例隔离,不跨任务累计")
|
|
|
+ void countArticleProgress_dailyIsolation() {
|
|
|
+ // 任务 A 已计 2 篇;任务 B(每日新实例)尚无进度
|
|
|
+ when(taskArticleProgressMapper.selectCount(any(Wrapper.class)))
|
|
|
+ .thenReturn(2L)
|
|
|
+ .thenReturn(0L);
|
|
|
+
|
|
|
+ assertEquals(2, service.countArticleProgress(TASK_ID));
|
|
|
+ assertEquals(0, service.countArticleProgress(TASK_ID + 1));
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- 门控(assertArticleTaskQualified)--------------------
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("B 模式未达标 → 门控拒绝「阅读时长不足」")
|
|
|
+ void gate_durationNotQualified_throws() {
|
|
|
+ Task task = durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300,\"requireQuiz\":false}");
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(0L);
|
|
|
+
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(task));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_DURATION_NOT_ENOUGH, ex.getMessage());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("C 模式进度不足 → 门控拒绝「阅读进度不足」")
|
|
|
+ void gate_countNotEnough_throws() {
|
|
|
+ Task task = countTask("{\"mode\":\"COUNT\",\"targetCount\":3,\"requireQuiz\":true,\"quizPassRate\":0.6}");
|
|
|
+ when(taskArticleProgressMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(task));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_PROGRESS_NOT_ENOUGH, ex.getMessage());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("配置缺失/解析失败 → 门控拒绝「阅读任务缺少配置」")
|
|
|
+ void gate_noConfig_throws() {
|
|
|
+ Task task = articleTask(null);
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(task));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_NO_CONFIG, ex.getMessage());
|
|
|
+
|
|
|
+ Task badJson = articleTask("{bad json");
|
|
|
+ IllegalArgumentException ex2 = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.assertArticleTaskQualified(badJson));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_NO_CONFIG, ex2.getMessage());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("非 article 任务 / null 任务 → 门控放行")
|
|
|
+ void gate_nonArticle_skips() {
|
|
|
+ Task normal = new Task();
|
|
|
+ normal.setId(1L);
|
|
|
+ normal.setActionType(null);
|
|
|
+ service.assertArticleTaskQualified(normal); // 不抛即放行
|
|
|
+
|
|
|
+ service.assertArticleTaskQualified(null);
|
|
|
+ }
|
|
|
+
|
|
|
+ // -------------------- parseConfig / 工具 --------------------
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("parseConfig:完整配置解析(ARTICLE)")
|
|
|
+ void parseConfig_article() {
|
|
|
+ Task task = articleTask("{\"mode\":\"ARTICLE\",\"articleId\":3001,\"minSeconds\":120,\"requireQuiz\":true,\"quizPassRate\":0.75}");
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig cfg = service.parseConfig(task);
|
|
|
+ assertNotNull(cfg);
|
|
|
+ assertEquals("ARTICLE", cfg.mode);
|
|
|
+ assertEquals(ARTICLE_ID, cfg.articleId);
|
|
|
+ assertEquals(120, cfg.minSeconds);
|
|
|
+ assertTrue(cfg.requireQuiz);
|
|
|
+ assertEquals(0.75, cfg.quizPassRate, 1e-9);
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("parseConfig:缺 mode 时按已填字段推断")
|
|
|
+ void parseConfig_modeInference() {
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig byArticle = service.parseConfig(
|
|
|
+ articleTask("{\"articleId\":3001}"));
|
|
|
+ assertEquals("ARTICLE", byArticle.mode);
|
|
|
+
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig byTarget = service.parseConfig(
|
|
|
+ articleTask("{\"targetCount\":3}"));
|
|
|
+ assertEquals("COUNT", byTarget.mode);
|
|
|
+
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig bySeconds = service.parseConfig(
|
|
|
+ durationTask("{\"minSeconds\":300}"));
|
|
|
+ assertEquals("DURATION", bySeconds.mode);
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("parseConfig:B 模式 requireQuiz 恒 false;quizPassRate 缺省取 sysConfig 再缺省 0.6")
|
|
|
+ void parseConfig_duration_requireQuizFalse_andRateFallback() {
|
|
|
+ when(sysConfigService.getValue(ArticleReadingTaskService.QUIZ_PASS_THRESHOLD_CONFIG_KEY)).thenReturn("0.8");
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig cfg = service.parseConfig(
|
|
|
+ durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300}"));
|
|
|
+ assertEquals("DURATION", cfg.mode);
|
|
|
+ assertFalse(cfg.requireQuiz);
|
|
|
+ assertEquals(0.8, cfg.quizPassRate, 1e-9);
|
|
|
+
|
|
|
+ when(sysConfigService.getValue(ArticleReadingTaskService.QUIZ_PASS_THRESHOLD_CONFIG_KEY)).thenReturn(null);
|
|
|
+ ArticleReadingTaskService.ReadingTaskConfig cfg2 = service.parseConfig(
|
|
|
+ durationTask("{\"mode\":\"DURATION\",\"minSeconds\":300}"));
|
|
|
+ assertEquals(ArticleReadingTaskService.DEFAULT_QUIZ_PASS_RATE, cfg2.quizPassRate, 1e-9);
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("articleQuizPassed:存在过题记录 → true;无记录/未达阈值 → false")
|
|
|
+ void articleQuizPassed() {
|
|
|
+ stubQuizPassed();
|
|
|
+ assertTrue(service.articleQuizPassed(MEMBER_ID, ARTICLE_ID, PASS_RATE));
|
|
|
+
|
|
|
+ when(articleQuizRecordMapper.selectList(any(Wrapper.class))).thenReturn(Collections.emptyList());
|
|
|
+ assertFalse(service.articleQuizPassed(MEMBER_ID, ARTICLE_ID, PASS_RATE));
|
|
|
+
|
|
|
+ assertFalse(service.articleQuizPassed(null, ARTICLE_ID, PASS_RATE));
|
|
|
+ assertFalse(service.articleQuizPassed(MEMBER_ID, null, PASS_RATE));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("durationQualified:达标 → true;时长不足/无关联记录 → false")
|
|
|
+ void durationQualified() {
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(1L);
|
|
|
+ assertTrue(service.durationQualified(TASK_ID, MEMBER_ID, MIN_SECONDS));
|
|
|
+
|
|
|
+ when(articleReadingRecordMapper.selectCount(any(Wrapper.class))).thenReturn(0L);
|
|
|
+ assertFalse(service.durationQualified(TASK_ID, MEMBER_ID, MIN_SECONDS));
|
|
|
+ assertFalse(service.durationQualified(TASK_ID, MEMBER_ID, 0));
|
|
|
+ assertFalse(service.durationQualified(null, MEMBER_ID, MIN_SECONDS));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("unfinished-ids:返回该成员已 reading_completed=1 的文章 id 集合与 total")
|
|
|
+ void unfinishedArticleIds() {
|
|
|
+ ArticleReadingRecord r1 = new ArticleReadingRecord();
|
|
|
+ r1.setArticleId(3001L);
|
|
|
+ ArticleReadingRecord r2 = new ArticleReadingRecord();
|
|
|
+ r2.setArticleId(3002L);
|
|
|
+ when(articleReadingRecordMapper.selectList(any(Wrapper.class)))
|
|
|
+ .thenReturn(Arrays.asList(r1, r2));
|
|
|
+
|
|
|
+ Map<String, Object> m = service.getUnfinishedArticleIds(MEMBER_ID);
|
|
|
+
|
|
|
+ @SuppressWarnings("unchecked")
|
|
|
+ List<Long> ids = (List<Long>) m.get("completedArticleIds");
|
|
|
+ assertEquals(2, ids.size());
|
|
|
+ assertEquals(2, m.get("total"));
|
|
|
+ assertTrue(ids.contains(3001L));
|
|
|
+ assertTrue(ids.contains(3002L));
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("getTaskProgress:任务不存在 / 配置缺失 → 抛对应文案")
|
|
|
+ void progress_errors() {
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(null);
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.getTaskProgress(TASK_ID));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_TASK_NOT_FOUND, ex.getMessage());
|
|
|
+
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(articleTask(null));
|
|
|
+ IllegalArgumentException ex2 = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> service.getTaskProgress(TASK_ID));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_NO_CONFIG, ex2.getMessage());
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("isTaskCompleted:completed → true;in_progress/不存在 → false")
|
|
|
+ void isTaskCompleted() {
|
|
|
+ Task done = new Task();
|
|
|
+ done.setId(TASK_ID);
|
|
|
+ done.setStatus("completed");
|
|
|
+ when(taskMapper.selectById(TASK_ID)).thenReturn(done);
|
|
|
+ assertTrue(service.isTaskCompleted(TASK_ID));
|
|
|
+
|
|
|
+ done.setStatus("in_progress");
|
|
|
+ assertFalse(service.isTaskCompleted(TASK_ID));
|
|
|
+ assertFalse(service.isTaskCompleted(null));
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== Group B:TaskService.completeTask 兜底门控(§5.2) ====================
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("§5.2:article 任务未过门控 → completeTask 抛对应文案(防前端绕过)")
|
|
|
+ void completeTask_articleGateRejected() throws Exception {
|
|
|
+ TaskService realTaskService = new TaskService();
|
|
|
+ TaskMapper tm = mock(TaskMapper.class);
|
|
|
+ FamilyMemberMapper fmm = mock(FamilyMemberMapper.class);
|
|
|
+ gateMock = mock(ArticleReadingTaskService.class);
|
|
|
+ inject(realTaskService, "taskMapper", tm);
|
|
|
+ inject(realTaskService, "familyMemberMapper", fmm);
|
|
|
+ inject(realTaskService, "articleReadingTaskService", gateMock);
|
|
|
+
|
|
|
+ Task task = new Task();
|
|
|
+ task.setId(TASK_ID);
|
|
|
+ task.setActionType("article");
|
|
|
+ task.setActionConfig("{\"mode\":\"DURATION\",\"minSeconds\":300,\"requireQuiz\":false}");
|
|
|
+ task.setStatus("pending");
|
|
|
+ task.setFamilyMemberId(MEMBER_ID);
|
|
|
+ when(tm.selectById(TASK_ID)).thenReturn(task);
|
|
|
+ org.mockito.Mockito.doThrow(new IllegalArgumentException(ArticleReadingTaskService.MSG_DURATION_NOT_ENOUGH))
|
|
|
+ .when(gateMock).assertArticleTaskQualified(task);
|
|
|
+
|
|
|
+ IllegalArgumentException ex = assertThrows(IllegalArgumentException.class,
|
|
|
+ () -> realTaskService.completeTask(TASK_ID, MEMBER_ID, null, null, null));
|
|
|
+ assertEquals(ArticleReadingTaskService.MSG_DURATION_NOT_ENOUGH, ex.getMessage());
|
|
|
+ verify(gateMock).assertArticleTaskQualified(task);
|
|
|
+ }
|
|
|
+
|
|
|
+ @Test
|
|
|
+ @DisplayName("§5.2:非 article 任务不触发门控(既有任务完成行为不变)")
|
|
|
+ void completeTask_nonArticleSkipsGate() throws Exception {
|
|
|
+ TaskService realTaskService = new TaskService();
|
|
|
+ TaskMapper tm = mock(TaskMapper.class);
|
|
|
+ FamilyMemberMapper fmm = mock(FamilyMemberMapper.class);
|
|
|
+ gateMock = mock(ArticleReadingTaskService.class);
|
|
|
+ // familyMemberMapper 供 T24-A 幂等结果取余额(此处返回 null 结余 0 即可)
|
|
|
+ inject(realTaskService, "taskMapper", tm);
|
|
|
+ inject(realTaskService, "familyMemberMapper", fmm);
|
|
|
+ inject(realTaskService, "articleReadingTaskService", gateMock);
|
|
|
+
|
|
|
+ // 任务已是完成态 → T24-A 幂等早返回,绝不应触达走阁门控
|
|
|
+ Task task = new Task();
|
|
|
+ task.setId(TASK_ID);
|
|
|
+ task.setActionType(null); // 非文章任务
|
|
|
+ task.setStatus("completed");
|
|
|
+ task.setFamilyMemberId(MEMBER_ID);
|
|
|
+ when(tm.selectById(TASK_ID)).thenReturn(task);
|
|
|
+
|
|
|
+ Map<String, Object> result = realTaskService.completeTask(TASK_ID, MEMBER_ID, null, null, null);
|
|
|
+
|
|
|
+ assertNotNull(result);
|
|
|
+ assertEquals(0, result.get("pointsEarned"));
|
|
|
+ verify(gateMock, never()).assertArticleTaskQualified(any(Task.class));
|
|
|
+ }
|
|
|
+
|
|
|
+ // ==================== 工具 ====================
|
|
|
+
|
|
|
+ private ArticleQuizRecord quizRecord(int score, int total) {
|
|
|
+ ArticleQuizRecord record = new ArticleQuizRecord();
|
|
|
+ record.setArticleId(ARTICLE_ID);
|
|
|
+ record.setMemberId(MEMBER_ID);
|
|
|
+ record.setScore(score);
|
|
|
+ record.setTotalQuestions(total);
|
|
|
+ return record;
|
|
|
+ }
|
|
|
+}
|