Explorar el Código

feat(S-cfc-320): admin.badge.manage 实现使绿 — 已发放勋章停用代替 + 管理端 role=admin 守卫

- BadgeService.deleteBadge: 存在成员授予记录(child_badge)时拒绝物理删除,
  改为停用(is_active=0),抛 IllegalStateException 提示;不声明 @Transactional
  保证停用 UPDATE 在异常前自提交持久化
- BadgeController /create|/update|/delete: 增加 role=admin 守卫(无权限返回 500)
- AdminChallengeScoreConfigController /update: 增加 role=admin 守卫
- RED 契约测试 AdminBadgeManageContractTest: 11 例全绿(5红→11绿)
Sisyphus hace 2 días
padre
commit
677490bc

+ 15 - 3
cfc-backend/src/main/java/com/etotem/cfc/controller/BadgeController.java

@@ -48,21 +48,33 @@ public class BadgeController {
 
     @Operation(summary = "创建勋章")
     @PostMapping("/create")
-    public Result<String> createBadge(@RequestBody Badge badge) {
+    public Result<String> createBadge(@RequestBody Badge badge,
+                                      @RequestAttribute("role") String role) {
+        if (!"admin".equals(role)) {
+            return Result.error("无权限");
+        }
         badgeService.createBadge(badge);
         return Result.success("创建成功");
     }
 
     @Operation(summary = "更新勋章")
     @PostMapping("/update")
-    public Result<String> updateBadge(@RequestBody Badge badge) {
+    public Result<String> updateBadge(@RequestBody Badge badge,
+                                      @RequestAttribute("role") String role) {
+        if (!"admin".equals(role)) {
+            return Result.error("无权限");
+        }
         badgeService.updateBadge(badge);
         return Result.success("更新成功");
     }
 
     @Operation(summary = "删除勋章")
     @PostMapping("/delete")
-    public Result<String> deleteBadge(@RequestBody Map<String, Object> body) {
+    public Result<String> deleteBadge(@RequestBody Map<String, Object> body,
+                                      @RequestAttribute("role") String role) {
+        if (!"admin".equals(role)) {
+            return Result.error("无权限");
+        }
         Long id = ParamUtils.getLong(body.get("id"));
         badgeService.deleteBadge(id);
         return Result.success("删除成功");

+ 5 - 1
cfc-backend/src/main/java/com/etotem/cfc/controller/admin/AdminChallengeScoreConfigController.java

@@ -32,7 +32,11 @@ public class AdminChallengeScoreConfigController {
 
     @Operation(summary = "更新挑战评分配置(按 action+scoreType)")
     @PostMapping("/update")
-    public Result<String> update(@RequestBody FamilyChallengeScoreConfig config) {
+    public Result<String> update(@RequestBody FamilyChallengeScoreConfig config,
+                                 @RequestAttribute("role") String role) {
+        if (!"admin".equals(role)) {
+            return Result.error("无权限");
+        }
         if (config.getAction() == null || config.getScoreType() == null) {
             return Result.error("action和scoreType不能为空");
         }

+ 20 - 1
cfc-backend/src/main/java/com/etotem/cfc/service/BadgeService.java

@@ -73,8 +73,27 @@ public class BadgeService {
         badgeMapper.updateById(badge);
     }
 
-    @Transactional
+    /**
+     * 删除勋章定义(SC-A-05 边界:已发放勋章不可物理删除,停用代替)。
+     * <p>
+     * 存在成员授予记录(child_badge 有该 badgeId)时:拒绝物理删除,改为停用
+     * (is_active=0,勋章墙仍可展示但不再新发),并抛 {@link IllegalStateException}
+     * 提示调用方(GlobalExceptionHandler 映射为 400 业务提示)。
+     * 本方法不声明 @Transactional:停用 UPDATE 需在异常抛出前自提交持久化,
+     * 避免事务回滚把停用动作一并撤销。
+     */
     public void deleteBadge(Long id) {
+        Long issuedCount = memberBadgeMapper.selectCount(
+                new LambdaQueryWrapper<MemberBadge>()
+                        .eq(MemberBadge::getBadgeId, id));
+        if (issuedCount != null && issuedCount > 0) {
+            Badge disable = new Badge();
+            disable.setId(id);
+            disable.setIsActive(0);
+            badgeMapper.updateById(disable);
+            log.info("勋章已发放,拒绝物理删除并自动停用: id={}, issuedCount={}", id, issuedCount);
+            throw new IllegalStateException("勋章已发放,不可删除,已停用代替(不再新发,已发放勋章墙仍展示)");
+        }
         badgeMapper.deleteById(id);
     }